New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventLoopFuture: use Result type #734

Merged
merged 1 commit into from Jan 5, 2019

Conversation

Projects
None yet
2 participants
@weissi
Copy link
Contributor

weissi commented Jan 4, 2019

Motivation:

Now that the stdlib has introduced the Result type, we can use it in the
implementation (and the whenComplete) function of EventLoopFuture

Modifications:

  • replace EventLoopValue with Result
  • make whenComplete provide the Result

Result:

use the new shiny stuff

@weissi weissi requested a review from Lukasa Jan 4, 2019

Johannes Weiss
EventLoopFuture: use Result type
Motivation:

Now that the stdlib has introduced the Result type, we can use it in the
implementation (and the whenComplete) function of EventLoopFuture

Modifications:

- replace EventLoopValue with Result
- make whenComplete provide the Result

Result:

use the new shiny stuff

@weissi weissi force-pushed the weissi:jw-use-result branch from 91cc0b3 to e0b3f81 Jan 4, 2019

@Lukasa

Lukasa approved these changes Jan 5, 2019

Copy link
Contributor

Lukasa left a comment

LGTM.

@Lukasa Lukasa merged commit 684cad3 into apple:master Jan 5, 2019

1 check passed

pull request validation (5.0) Build finished.
Details

@weissi weissi deleted the weissi:jw-use-result branch Jan 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment