New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename HTTPProtocolUpgrader to HTTPServerProtocolUpgrader #750

Merged
merged 8 commits into from Jan 31, 2019

Conversation

Projects
None yet
3 participants
@tanner0101
Copy link
Contributor

tanner0101 commented Jan 15, 2019

This PR renames HTTPProtocolUpgrader to HTTPServerProtocolUpgrader

Motivation:

The HTTPProtocolUpgrader protocol supports only server upgrades. This protocol should be renamed to include the word Server to help differentiate from protocol upgraders meant for client usage (likely named HTTPClientProtocolUpgrader).

Modifications:

Renamed all instances of HTTPProtocolUpgrader to HTTPServerProtocolUpgrader in code and comments.

Renamed HTTPUpgrade... types to HTTPServerUpgrade...

Result:

It is now more clear that this protocol is meant for usage with HTTP server handlers. It is also more clear what client upgrade protocols should be named. This is useful for users of NIO and also will be helpful if NIO decides to add client upgrade logic in the future.

tanner0101 added some commits Jun 3, 2018

@Lukasa Lukasa added this to the 2.0.0 milestone Jan 16, 2019

@Lukasa
Copy link
Contributor

Lukasa left a comment

This looks reasonable to me, but can you add a note to the public-api-changes-NIO1-to-NIO2 doc please?

tanner0101 added some commits Jan 29, 2019

@tanner0101

This comment has been minimized.

Copy link
Contributor Author

tanner0101 commented Jan 29, 2019

Hey @Lukasa, sorry for the delay. Does the line added in public-api-changes-NIO1-to-NIO2 look good?

@weissi
Copy link
Contributor

weissi left a comment

sorry @tanner0101 , would you mind also putting the appropriate deprecated typealiases/... into the _NIO1APIShims module?

tanner0101 added some commits Jan 30, 2019

@tanner0101

This comment has been minimized.

Copy link
Contributor Author

tanner0101 commented Jan 30, 2019

@weissi no problem, added. :)

@weissi

weissi approved these changes Jan 30, 2019

Copy link
Contributor

weissi left a comment

Thanks v much, lgtm

@weissi

This comment has been minimized.

Copy link
Contributor

weissi commented Jan 30, 2019

@swift-nio-bot test this please

@Lukasa

Lukasa approved these changes Jan 31, 2019

@Lukasa Lukasa merged commit 0154604 into apple:master Jan 31, 2019

1 check passed

pull request validation (5.0) Build finished.
Details

@tanner0101 tanner0101 deleted the tanner0101:server-protocol-upgrader-rename branch Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment