New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide _NIO1APIShims #758

Merged
merged 2 commits into from Jan 21, 2019

Conversation

Projects
None yet
3 participants
@weissi
Copy link
Contributor

weissi commented Jan 19, 2019

Motivation:

For package authors, the NIO1 to 2 transition can be taxing because we
keep changing things. So far, the community has done an incredible job
keeping up with our changes but we'd like to make it as easy as possible
continuing to do so.

Modifications:

  • add a _NIO1APIShims module that when imported tries to provide some
    of the NIO1 API in NIO2 with helpful fixup messages

Result:

easier transition from NIO1 to NIO2

@weissi weissi requested a review from Lukasa Jan 19, 2019

@weissi

This comment has been minimized.

Copy link
Contributor Author

weissi commented Jan 19, 2019

CC @ianpartridge / @tanner0101 let me know what you think

@weissi weissi force-pushed the weissi:jw-nio1-api-shims branch 2 times, most recently from 5ce670f to f2fac10 Jan 19, 2019

@weissi weissi added this to the 2.0.0 milestone Jan 19, 2019

@weissi

This comment has been minimized.

Copy link
Contributor Author

weissi commented Jan 19, 2019

needs to also have #760's renames

@Lukasa
Copy link
Contributor

Lukasa left a comment

Generally love this, a few questions inline.

Show resolved Hide resolved Sources/_NIO1APIShims/NIO1APIShims.swift Outdated
Show resolved Hide resolved Sources/_NIO1APIShims/NIO1APIShims.swift Outdated
}

extension MarkedCircularBuffer {
@available(*, deprecated, message: "hasMark is now a property, remove `()`")

This comment has been minimized.

@Lukasa

Lukasa Jan 19, 2019

Contributor

Are these deprecated or replaced?

This comment has been minimized.

@weissi

weissi Jan 21, 2019

Author Contributor

there's no replace, is there?

}

public enum MulticastError {
@available(*, deprecated, message: "MulticastError values are now available on ChannelError")

This comment has been minimized.

@Lukasa

Lukasa Jan 19, 2019

Contributor

Are these renamed also?

This comment has been minimized.

@weissi

weissi Jan 21, 2019

Author Contributor

@Lukasa good point, I added on the type that it has been renamed.

@ianpartridge

This comment has been minimized.

Copy link
Contributor

ianpartridge commented Jan 19, 2019

Well you guys are just the nicest. Thanks.

provide _NIO1APIShims
Motivation:

For package authors, the NIO1 to 2 transition can be taxing because we
keep changing things. So far, the community has done an incredible job
keeping up with our changes but we'd like to make it as easy as possible
continuing to do so.

Modifications:

- add a `_NIO1APIShims` module that when imported tries to provide some
  of the NIO1 API in NIO2 with helpful fixup messages

Result:

easier transition from NIO1 to NIO2

@weissi weissi force-pushed the weissi:jw-nio1-api-shims branch from f2fac10 to cbad102 Jan 21, 2019

@weissi

This comment has been minimized.

Copy link
Contributor Author

weissi commented Jan 21, 2019

blocked by #765

@Lukasa

Lukasa approved these changes Jan 21, 2019

@Lukasa Lukasa merged commit 9033aa6 into apple:master Jan 21, 2019

1 check passed

pull request validation (5.0) Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment