Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upstandardize `ELF.cascade*` collection of methods #802
Conversation
This comment has been minimized.
This comment has been minimized.
swift-nio-bot
commented
Feb 2, 2019
|
Can one of the admins verify this patch? |
3 similar comments
This comment has been minimized.
This comment has been minimized.
swift-nio-bot
commented
Feb 2, 2019
|
Can one of the admins verify this patch? |
This comment has been minimized.
This comment has been minimized.
swift-nio-bot
commented
Feb 2, 2019
|
Can one of the admins verify this patch? |
This comment has been minimized.
This comment has been minimized.
swift-nio-bot
commented
Feb 2, 2019
|
Can one of the admins verify this patch? |
Mordil
changed the title
Cascade
Standardize EventLoopFuture.cascade method collection
Feb 2, 2019
Mordil
changed the title
Standardize EventLoopFuture.cascade method collection
Standardize ELF cascade method collection
Feb 2, 2019
Lukasa
requested changes
Feb 4, 2019
|
Thanks for this! Generally looks good, but I've left some notes in the diff. Can you also use the commit message template? Thanks! |
This comment has been minimized.
This comment has been minimized.
|
@Lukasa Should the commit message template be used in the PR's description & title, or should I squash and update the commit message directly in git? |
This comment has been minimized.
This comment has been minimized.
|
Squash and update in Git, please :) |
Mordil
force-pushed the
Mordil:cascade
branch
from
004b7ac
to
96801f5
Feb 4, 2019
Mordil
changed the title
Standardize ELF cascade method collection
standardize `ELF.cascade*` collection of methods
Feb 4, 2019
This comment has been minimized.
This comment has been minimized.
|
Done - this should be good for final review :) |
Mordil
force-pushed the
Mordil:cascade
branch
from
96801f5
to
40661d6
Feb 4, 2019
Lukasa
approved these changes
Feb 4, 2019
This comment has been minimized.
This comment has been minimized.
|
@swift-nio-bot test this please |
Lukasa
added
the
⚠️ needs-major-version-bump
label
Feb 4, 2019
Lukasa
added this to the 2.0.0 milestone
Feb 4, 2019
This comment has been minimized.
This comment has been minimized.
|
@swift-nio-bot test this please |
Lukasa
merged commit caf9a3d
into
apple:master
Feb 5, 2019
1 check passed
pull request validation (5.0)
Build finished.
Details
Mordil
deleted the
Mordil:cascade
branch
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Mordil commentedFeb 2, 2019
•
edited
Motivation:
The
ELF.cascademethods have a parameter labelpromisethat does not match Swift API Guidelines, and a way to cascade just successes is not available - while for failures there is.Modifications:
ELF.cascade*methods that already exist have had theirpromiselabel renamed toto, and a newELF.cascadeSuccessmethod has been added.Result:
EventLoopFuture now has the cascade methods
ELF.cascade(to:),ELF.cascadeFailure(to:), andELF.cascadeSuccess(to:)