New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TCP_INFO/TCP_CONNECTION_INFO queries. #811

Merged
merged 1 commit into from Feb 11, 2019

Conversation

Projects
None yet
2 participants
@Lukasa
Copy link
Contributor

Lukasa commented Feb 11, 2019

Motivation:

Many users may wish to see the underlying TCP connection state for
important calculations, such as for BDP or RTT numbers. We can make this
available easily enough.

Modifications:

  • Added a function to get TCP_INFO on Linux/FreeBSD.
  • Added a function to get TCP_CONNECTION_INFO on Darwin.

Result:

Better connection stats

Add TCP_INFO/TCP_CONNECTION_INFO queries.
Motivation:

Many users may wish to see the underlying TCP connection state for
important calculations, such as for BDP or RTT numbers. We can make this
available easily enough.

Modifications:

- Added a function to get TCP_INFO on Linux/FreeBSD.
- Added a function to get TCP_CONNECTION_INFO on Darwin.

Result:

Better connection stats

@Lukasa Lukasa added this to the 2.0.0 milestone Feb 11, 2019

@Lukasa Lukasa requested a review from weissi Feb 11, 2019

@weissi

weissi approved these changes Feb 11, 2019

Copy link
Contributor

weissi left a comment

thanks! LGTM

@weissi weissi merged commit 2738b6d into apple:master Feb 11, 2019

1 check passed

pull request validation (5.0) Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment