Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove WebSocketFrameDecoder inline error handling #885

Merged
merged 3 commits into from Mar 8, 2019

Conversation

Projects
None yet
3 participants
@weissi
Copy link
Member

weissi commented Mar 8, 2019

Motivation:

Follows on from the work done in #528 for #527: we have moved the the
default error handling out of WebSocketFrameDecoder, but had to leave
the code there for backward compatibility reasons. We can remove that
code now.

Modifications:

Removed automatic error handling code in WebSocketFrameDecoder.

Result:

@weissi weissi requested a review from Lukasa Mar 8, 2019

@weissi weissi added this to the 2.0.0 milestone Mar 8, 2019

@weissi weissi requested a review from normanmaurer Mar 8, 2019

@weissi weissi requested a review from normanmaurer Mar 8, 2019

@weissi weissi force-pushed the weissi:jw-534 branch from 20dfb75 to 5b389f7 Mar 8, 2019

remove WebSocketFrameDecoder inline error handling
Motivation:

Follows on from the work done in #528 for #527: we have moved the the
default error handling out of WebSocketFrameDecoder, but had to leave
the code there for backward compatibility reasons. We can remove that
code now.

Modifications:

Removed automatic error handling code in WebSocketFrameDecoder.

Result:

- fixes #534

@weissi weissi force-pushed the weissi:jw-534 branch from bb3d337 to dbc7610 Mar 8, 2019

@weissi weissi requested review from normanmaurer and Lukasa and removed request for normanmaurer and Lukasa Mar 8, 2019

@Lukasa

Lukasa approved these changes Mar 8, 2019

Apologies, need to get home soon and need to tag still. Addressed your feedback and @Lukasa approved it, hence dismissing this :P

@weissi weissi merged commit 36a52e1 into apple:master Mar 8, 2019

1 check passed

pull request validation (5.0) Build finished.
Details

@weissi weissi deleted the weissi:jw-534 branch Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.