Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable NIO1APIShim's warning #889

Merged
merged 1 commit into from Mar 8, 2019

Conversation

Projects
None yet
2 participants
@weissi
Copy link
Member

weissi commented Mar 8, 2019

Motivation:

We shouldn't put warnings in developer's code in the convergence phase.

Modifications:

  • remove NIO1APIShims warning
  • update Swift

Result:

fewer warnings

disable NIO1APIShim's warning
Motivation:

We shouldn't put warnings in developer's code in the convergence phase.

Modifications:

- remove NIO1APIShims warning
- update Swift

Result:

fewer warnings

@weissi weissi requested a review from normanmaurer Mar 8, 2019

@weissi weissi added this to the 2.0.0 milestone Mar 8, 2019

@weissi weissi merged commit 577604e into apple:master Mar 8, 2019

1 check passed

pull request validation (5.0) Build finished.
Details

@weissi weissi deleted the weissi:jw-disable-shims-warning branch Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.