Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP1 example server: don't crash on empty file served #962

Merged
merged 1 commit into from Apr 10, 2019

Conversation

Projects
None yet
2 participants
@weissi
Copy link
Member

weissi commented Apr 10, 2019

Motivation:

The file-io implementation in the example HTTP1 server just crashed on
empty file ;).

Modifications:

  • fix the crash
  • add integration test

Result:

fewer crashes

HTTP1 example server: don't crash on empty file served
Motivation:

The file-io implementation in the example HTTP1 server just crashed on
empty file ;).

Modifications:

- fix the crash
- add integration test

Result:

fewer crashes

@weissi weissi requested a review from Lukasa Apr 10, 2019

@Lukasa

Lukasa approved these changes Apr 10, 2019

@Lukasa Lukasa merged commit c90b159 into apple:master Apr 10, 2019

1 check passed

pull request validation (5.0) Build finished.
Details

weissi added a commit that referenced this pull request Apr 12, 2019

HTTP1 example server: don't crash on empty file served (#962)
Motivation:

The file-io implementation in the example HTTP1 server just crashed on
empty file ;).

Modifications:

- fix the crash
- add integration test

Result:

fewer crashes

(cherry picked from commit c90b159)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.