Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: fix outdated info #979

Merged
merged 2 commits into from Apr 23, 2019

Conversation

Projects
None yet
3 participants
@weissi
Copy link
Member

commented Apr 23, 2019

Motivation:

The link to swift.org linked to the Swift 5 development versions but now
it's released. We also mentioned swift-nio-{http2,ssl,extras,transport-services}
but we already mention them in a more prominent place.

Modifications:

Remove outdated/duped info.

Result:

Better readme

README: fix outdated info
Motivation:

The link to swift.org linked to the Swift 5 development versions but now
it's released. We also mentioned swift-nio-{http2,ssl,extras,transport-services}
but we already mention them in a more prominent place.

Modifications:

Remove outdated/duped info.

Result:

Better readme

@weissi weissi requested a review from normanmaurer Apr 23, 2019

@tomerd

tomerd approved these changes Apr 23, 2019

@tomerd

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

flaky test? @swift-nio-bot test this please

10:49:11 Fatal error: Posix wrapper adds more than 20% overhead (with wrapper: 0.8163410425186157, without: 0.6731261014938354: file /tmp/.swift-nio-syscall-wrappers-sh-test_myuiEq/syscallwrapper/Sources/syscallwrapper/SystemCallWrapperHelpers.swift, line 124
10:49:11 /code/IntegrationTests/tests_02_syscall_wrappers/test_01_syscall_wrapper_fast.sh: line 45: 13246 Illegal instruction     (core dumped) "$swift_binary" run -c release -Xswiftc -DRUNNING_INTEGRATION_TESTS

/cc @weissi

@weissi

This comment has been minimized.

Copy link
Member Author

commented Apr 23, 2019

@tomerd that's a performance test which sometimes fails if the CI is running too much stuff at the same time... When we do the performance effort, this one can go out of the unit test suite...

@weissi weissi merged commit 902cf2e into apple:master Apr 23, 2019

1 check passed

pull request validation (5.0) Build finished.
Details

@weissi weissi deleted the weissi:jw-outdated-readme branch Apr 23, 2019

@Lukasa Lukasa added this to the 2.1.0 milestone May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.