Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new alloc counter tests #996

Merged
merged 1 commit into from May 9, 2019

Conversation

Projects
None yet
2 participants
@weissi
Copy link
Member

commented May 3, 2019

Motivation:

Previously, writing an allocation test was quite hard, the allocation tests
were hard to debug and also the allocation testing framework and the
allocations tests were mangled together. That was bad and therefore
we never started writing allocation tests for other NIO repositories such
as swift-nio-http2.

Modifications:

  • Make it easy to write alloc tests (just drop a test_...swift file in a folder).
  • separate the alloc counter framework from the tests

Result:

  • easier to write allocation tests
  • 'productise' the alloc counter framework

@weissi weissi force-pushed the weissi:jw-new-alloc-counter-tests branch 2 times, most recently from 66cbe6c to e6c777d May 3, 2019

@weissi weissi marked this pull request as ready for review May 7, 2019

@weissi weissi requested a review from Lukasa May 7, 2019

@Lukasa

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

Looks like we have some test failures here. 😁

@weissi

This comment has been minimized.

Copy link
Member Author

commented May 8, 2019

@Lukasa ha, it expects package id to be the same as package basename :P:

18:57:02 Completed resolution in 0.62s
18:57:02 error: package at '/code' is swift-nio but was expecting code

but we check the code out into /code... Will fix

@weissi weissi force-pushed the weissi:jw-new-alloc-counter-tests branch from e6c777d to cf0242e May 8, 2019

@weissi weissi added this to the 2.1.0 milestone May 8, 2019

@Lukasa

Lukasa approved these changes May 9, 2019

@Lukasa Lukasa merged commit 5d1d598 into apple:master May 9, 2019

2 checks passed

pull request validation (5.0) Build finished.
Details
pull request validation (5.1) Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.