From 95d01609683cfafc9e2aef2718acff06c8af25aa Mon Sep 17 00:00:00 2001 From: omochimetaru Date: Thu, 5 Oct 2023 05:22:57 +0900 Subject: [PATCH] Fix to call `didFinishCommand` (#6757) When `XCBuildDelegate` receives a `taskComplete` message, it calls `buildSystem(:didStartCommand:)` of `BuildSystemDelegate`. However, it should probably call `buildSystem(:didFinishCommand:)`. Since there doesn't seem to be any concrete type conforming to `BuildSystemDelegate`, this change doesn't appear to have any impact on the behavior of existing code. --- Sources/XCBuildSupport/XCBuildDelegate.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Sources/XCBuildSupport/XCBuildDelegate.swift b/Sources/XCBuildSupport/XCBuildDelegate.swift index 46393936a2a..59d18b810d9 100644 --- a/Sources/XCBuildSupport/XCBuildDelegate.swift +++ b/Sources/XCBuildSupport/XCBuildDelegate.swift @@ -81,7 +81,7 @@ extension XCBuildDelegate: XCBuildOutputParserDelegate { } case .taskComplete(let info): queue.async { - self.buildSystem.delegate?.buildSystem(self.buildSystem, didStartCommand: BuildSystemCommand(name: "\(info.taskID)", description: info.result.rawValue)) + self.buildSystem.delegate?.buildSystem(self.buildSystem, didFinishCommand: BuildSystemCommand(name: "\(info.taskID)", description: info.result.rawValue)) } case .buildDiagnostic(let info): queue.async {