From fcad10981a5b2375ba96dbe0e4a757005cad7be5 Mon Sep 17 00:00:00 2001 From: tomer doron Date: Tue, 3 Oct 2023 12:00:10 -0700 Subject: [PATCH] filter out expected signals when logging test crashing motivation: nicer user experience when terminating tests changes: filter out logging of signal used when terminating tests normally radar/113751498 --- Sources/Commands/SwiftTestTool.swift | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/Sources/Commands/SwiftTestTool.swift b/Sources/Commands/SwiftTestTool.swift index f6787d85174..c83f8c71093 100644 --- a/Sources/Commands/SwiftTestTool.swift +++ b/Sources/Commands/SwiftTestTool.swift @@ -14,9 +14,7 @@ import ArgumentParser import Basics import CoreCommands import Dispatch -import class Foundation.JSONDecoder -import class Foundation.NSLock -import class Foundation.ProcessInfo +import Foundation import PackageGraph import PackageModel import SPMBuildCore @@ -698,8 +696,8 @@ final class TestRunner { case .terminated(code: 0): return true #if !os(Windows) - case .signalled(let signal): - testObservabilityScope.emit(error: "Exited with signal code \(signal)") + case .signalled(let signal) where ![SIGINT, SIGKILL, SIGTERM].contains(signal): + testObservabilityScope.emit(error: "Exited with unexpected signal code \(signal)") return false #endif default: