[SR-15758] Fast path does not take effect cause no return.

[swift-ci]

Previous ID	SR-15758
Radar	None
Original Reporter	Meng94 (JIRA User)
Type	Improvement

Additional Detail from JIRA

Votes	0
Component/s	Package Manager
Labels	Improvement
Assignee	None
Priority	Medium

md5: f7cfd73ccf04d925250424b0e281cf7a

Issue Description:

Summary: It is not take effect in swift-tools-support-core UNIXPath fast init.
Description: UNIXPath in Path.swift line 562, called `self.init(string: path)`, but no return, this cause no effect with fast path.

private struct UNIXPath: Path {
    // ...
    // Fast path
    init(normalizingAbsolutePath path: String) {
        // ...
        if !mayNeedNormalization(absolute: path) {
            self.init(string: path) 
            // no return to take effect.
        }
        // ...

        self.init(string: result)
    }
}

I write demo and output like this:

struct Test {
    let string: String


    init(string1: String) {
        self.string = string
    }


    init(string2: String) {
        if string2 == "1" {
            self.init(string1: string2 + " with if")
            // return
        }
        self.init(string1: string2 + " without if")
    }
}

print(Test(string2: "1").string) // '1 without if', which should be '1 with if' when add return.
print(Test(string2: "2").string) // '2 without if'