Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-15196] Binary target required for compilation despite being a conditional dependency #4388

Open
swift-ci opened this issue Sep 14, 2021 · 1 comment
Labels

Comments

@swift-ci
Copy link
Contributor

@swift-ci swift-ci commented Sep 14, 2021

Previous ID SR-15196
Radar rdar://problem/83153139
Original Reporter gbrhaz (JIRA User)
Type Bug
Environment

Xcode 12.5.1

Xcode 13.0 beta 5

Additional Detail from JIRA
Votes 4
Component/s Package Manager
Labels Bug
Assignee None
Priority Medium

md5: 923498cd24ed244edda804515f08d0dd

is duplicated by:

  • SR-15836 Platform Conditionals Don't Apply To Binary Frameworks

Issue Description:

SPM has recently introduced conditional dependencies and binary targets (for xcframeworks). The two do not align, however. A binary dependency that is supported only on one platform is still linked on unsupported platforms.

I have created a repository here that I think showcases the issue:

https://github.com/gbrhaz/spm-binary-conditional

In the repository I have added the GoogleCast frameworks into an xcframework. Since GoogleCast is only supported for iOS, the xcframework supports architectures for iOS and x64 Simulator.

I want to depend on GoogleCast - but only for iOS platform, not for tvOS.

In the above repository I have also added a source-only dependency that can showcase how conditional dependencies do work for source-only frameworks. It appears to only be binary dependencies that cause issues.

@typesanitizer
Copy link

@typesanitizer typesanitizer commented Sep 15, 2021

@swift-ci create

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants