Add support for empty source packages #149
Conversation
ankitspd
force-pushed
the
patch-9
branch
2 times, most recently
from
7cd56e3
to
95b4391
Compare
|
@swift-ci Please test |
|
@mxcl should I update anything? |
| modules = try package.modules() | ||
| } catch Package.ModuleError.NoModules(let pkg) where pkg.path == rootdir { | ||
| //Ignore and print warning if root package doesn't contain any sources | ||
| print("warning: root package '\(pkg)' does not contain any sources") |
There was a problem hiding this comment.
Would be great to handle warning in similar way to errors.
That way we could hold warnings in one place and make them statically typed, by using enums.
Also we could use different text color for warnings as well.
But maybe it's out of the scope for that PR.
There was a problem hiding this comment.
Yeah, agreed. I was actually thinking to do that but thought it'd be too much for this PR. I would love to take a shot at that in a sep. PR
|
rebased |
|
@mxcl trigger CI please |
|
@swift-ci Please test |
Add support for empty source packages
|
I was just going to comment that merging this would create conflict in #174 |
|
That's OK I can resolve my own PR conflicts. 💪🏻 |
|
😂Yeah just wasn't sure if its ok for that and swift-3-api to be conflicted as they're major things right now as you said 🖖 |
|
Oh indeed, but as long as we're on top of it, the vast Swift machine will keep turning. I'm fixing up those branches as we speak. |
[BuildSystem] Fix yet another cancellation race
Fixes https://bugs.swift.org/browse/SR-793
I am not sure if rootdir should be passed to transmute method, maybe Package should have a property isRoot ?