New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for empty source packages #149

Merged
merged 2 commits into from Mar 9, 2016

Conversation

Projects
None yet
3 participants
@aciidb0mb3r
Member

aciidb0mb3r commented Feb 25, 2016

Fixes https://bugs.swift.org/browse/SR-793

I am not sure if rootdir should be passed to transmute method, maybe Package should have a property isRoot ?

@mxcl

This comment has been minimized.

Show comment
Hide comment
@mxcl

mxcl Feb 27, 2016

Contributor

@swift-ci Please test

Contributor

mxcl commented Feb 27, 2016

@swift-ci Please test

@aciidb0mb3r

This comment has been minimized.

Show comment
Hide comment
@aciidb0mb3r

aciidb0mb3r Mar 1, 2016

Member

@mxcl should I update anything?

Member

aciidb0mb3r commented Mar 1, 2016

@mxcl should I update anything?

modules = try package.modules()
} catch Package.ModuleError.NoModules(let pkg) where pkg.path == rootdir {
//Ignore and print warning if root package doesn't contain any sources
print("warning: root package '\(pkg)' does not contain any sources")

This comment has been minimized.

@kostiakoval

kostiakoval Mar 1, 2016

Collaborator

Would be great to handle warning in similar way to errors.
That way we could hold warnings in one place and make them statically typed, by using enums.
Also we could use different text color for warnings as well.
But maybe it's out of the scope for that PR.

@kostiakoval

kostiakoval Mar 1, 2016

Collaborator

Would be great to handle warning in similar way to errors.
That way we could hold warnings in one place and make them statically typed, by using enums.
Also we could use different text color for warnings as well.
But maybe it's out of the scope for that PR.

This comment has been minimized.

@aciidb0mb3r

aciidb0mb3r Mar 1, 2016

Member

Yeah, agreed. I was actually thinking to do that but thought it'd be too much for this PR. I would love to take a shot at that in a sep. PR

@aciidb0mb3r

aciidb0mb3r Mar 1, 2016

Member

Yeah, agreed. I was actually thinking to do that but thought it'd be too much for this PR. I would love to take a shot at that in a sep. PR

@aciidb0mb3r

This comment has been minimized.

Show comment
Hide comment
@aciidb0mb3r

aciidb0mb3r Mar 2, 2016

Member

rebased

Member

aciidb0mb3r commented Mar 2, 2016

rebased

@aciidb0mb3r

This comment has been minimized.

Show comment
Hide comment
@aciidb0mb3r

aciidb0mb3r Mar 8, 2016

Member

@mxcl trigger CI please

Member

aciidb0mb3r commented Mar 8, 2016

@mxcl trigger CI please

@mxcl

This comment has been minimized.

Show comment
Hide comment
@mxcl

mxcl Mar 9, 2016

Contributor

@swift-ci Please test

Contributor

mxcl commented Mar 9, 2016

@swift-ci Please test

mxcl added a commit that referenced this pull request Mar 9, 2016

Merge pull request #149 from aciidb0mb3r/patch-9
Add support for empty source packages

@mxcl mxcl merged commit f99a652 into apple:master Mar 9, 2016

2 checks passed

Swift Test Linux Platform Build finished. 7988 tests run, 0 skipped, 0 failed.
Details
Swift Test OS X Platform Build finished. 32116 tests run, 0 skipped, 0 failed.
Details
@aciidb0mb3r

This comment has been minimized.

Show comment
Hide comment
@aciidb0mb3r

aciidb0mb3r Mar 9, 2016

Member

I was just going to comment that merging this would create conflict in #174

Member

aciidb0mb3r commented Mar 9, 2016

I was just going to comment that merging this would create conflict in #174

@mxcl

This comment has been minimized.

Show comment
Hide comment
@mxcl

mxcl Mar 9, 2016

Contributor

That's OK I can resolve my own PR conflicts. 💪🏻

Contributor

mxcl commented Mar 9, 2016

That's OK I can resolve my own PR conflicts. 💪🏻

@aciidb0mb3r aciidb0mb3r deleted the aciidb0mb3r:patch-9 branch Mar 9, 2016

@aciidb0mb3r

This comment has been minimized.

Show comment
Hide comment
@aciidb0mb3r

aciidb0mb3r Mar 9, 2016

Member

😂Yeah just wasn't sure if its ok for that and swift-3-api to be conflicted as they're major things right now as you said 🖖

Member

aciidb0mb3r commented Mar 9, 2016

😂Yeah just wasn't sure if its ok for that and swift-3-api to be conflicted as they're major things right now as you said 🖖

@mxcl

This comment has been minimized.

Show comment
Hide comment
@mxcl

mxcl Mar 9, 2016

Contributor

Oh indeed, but as long as we're on top of it, the vast Swift machine will keep turning. I'm fixing up those branches as we speak.

Contributor

mxcl commented Mar 9, 2016

Oh indeed, but as long as we're on top of it, the vast Swift machine will keep turning. I'm fixing up those branches as we speak.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment