pass fd to PackageDescription while parsing manifests instead of using SWIFT_DUMP_PACKAGE #169

Merged
merged 3 commits into from Mar 9, 2016

Conversation

Projects
None yet
2 participants
@aciidb0mb3r
Member

aciidb0mb3r commented Mar 3, 2016

No description provided.

@mxcl

This comment has been minimized.

Show comment
Hide comment
@mxcl

mxcl Mar 3, 2016

Contributor

Looks good. I am currently waiting on the swift-3-api-guidelines merge before merging anything new.

Contributor

mxcl commented Mar 3, 2016

Looks good. I am currently waiting on the swift-3-api-guidelines merge before merging anything new.

@mxcl

This comment has been minimized.

Show comment
Hide comment
@mxcl

mxcl Mar 5, 2016

Contributor

I'm going to start merging everything, as I hoped the swift 3 apis would be merged this week, but it looks like it will be longer.

Contributor

mxcl commented Mar 5, 2016

I'm going to start merging everything, as I hoped the swift 3 apis would be merged this week, but it looks like it will be longer.

@mxcl

This comment has been minimized.

Show comment
Hide comment
@mxcl

mxcl Mar 8, 2016

Contributor

@swift-ci Please test

Contributor

mxcl commented Mar 8, 2016

@swift-ci Please test

@aciidb0mb3r

This comment has been minimized.

Show comment
Hide comment
@aciidb0mb3r

aciidb0mb3r Mar 8, 2016

Member
/home/buildnode/jenkins/workspace/swift-package-manager-PR-Linux/swiftpm/Sources/ManifestParser/Manifest+parse.swift:74:13: error: use of unresolved identifier 'fclose'
    defer { fclose(fp) }
            ^~~~~~
<unknown>:0: error: build had 1 command failures

This did not error for me on OSX and Ubuntu 15.10
CI looks like to be on 14.04, will check.

Member

aciidb0mb3r commented Mar 8, 2016

/home/buildnode/jenkins/workspace/swift-package-manager-PR-Linux/swiftpm/Sources/ManifestParser/Manifest+parse.swift:74:13: error: use of unresolved identifier 'fclose'
    defer { fclose(fp) }
            ^~~~~~
<unknown>:0: error: build had 1 command failures

This did not error for me on OSX and Ubuntu 15.10
CI looks like to be on 14.04, will check.

@aciidb0mb3r

This comment has been minimized.

Show comment
Hide comment
@aciidb0mb3r

aciidb0mb3r Mar 8, 2016

Member

This is weird, It works for me on Ubuntu 14.04 too.
Latest toolchain

Swift version 3.0-dev (LLVM b361b0fc05, Clang 11493b0f62, Swift 24a0c3de75)
Target: x86_64-unknown-linux-gnu
Member

aciidb0mb3r commented Mar 8, 2016

This is weird, It works for me on Ubuntu 14.04 too.
Latest toolchain

Swift version 3.0-dev (LLVM b361b0fc05, Clang 11493b0f62, Swift 24a0c3de75)
Target: x86_64-unknown-linux-gnu
@mxcl

This comment has been minimized.

Show comment
Hide comment
@mxcl

mxcl Mar 8, 2016

Contributor

Probably would be fixed if you import func libc.fclose

Contributor

mxcl commented Mar 8, 2016

Probably would be fixed if you import func libc.fclose

@aciidb0mb3r

This comment has been minimized.

Show comment
Hide comment
@aciidb0mb3r

aciidb0mb3r Mar 8, 2016

Member

I figured but weird that CI errors out where as nothing on local

Member

aciidb0mb3r commented Mar 8, 2016

I figured but weird that CI errors out where as nothing on local

@aciidb0mb3r

This comment has been minimized.

Show comment
Hide comment
@aciidb0mb3r

aciidb0mb3r Mar 8, 2016

Member

@mxcl trigger CI please

Member

aciidb0mb3r commented Mar 8, 2016

@mxcl trigger CI please

@mxcl

This comment has been minimized.

Show comment
Hide comment
@mxcl

mxcl Mar 9, 2016

Contributor

@swift-ci Please test

Contributor

mxcl commented Mar 9, 2016

@swift-ci Please test

@aciidb0mb3r

This comment has been minimized.

Show comment
Hide comment
@aciidb0mb3r

aciidb0mb3r Mar 9, 2016

Member

CI succeeded merging

Member

aciidb0mb3r commented Mar 9, 2016

CI succeeded merging

aciidb0mb3r added a commit that referenced this pull request Mar 9, 2016

Merge pull request #169 from aciidb0mb3r/pass_fd
pass fd to PackageDescription while parsing manifests instead of using SWIFT_DUMP_PACKAGE

@aciidb0mb3r aciidb0mb3r merged commit 989f373 into apple:master Mar 9, 2016

2 checks passed

Swift Test Linux Platform Build finished. 7988 tests run, 0 skipped, 0 failed.
Details
Swift Test OS X Platform Build finished. 32116 tests run, 0 skipped, 0 failed.
Details

@aciidb0mb3r aciidb0mb3r deleted the aciidb0mb3r:pass_fd branch Mar 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment