Fully conform to Semantic Versioning 2.0.0 spec #64
Conversation
|
Specifier doesn't want support there since it is intended to represent part of the 3 number tuple. Correct me if wrong @mattt |
|
Will pull when we have tests. If you haven't the time, I can write them. |
|
Great work! |
| continue | ||
| } | ||
|
|
||
| let castedLhsIdentifier: Any = Int(lhsPrereleaseIdentifier) ?? lhsPrereleaseIdentifier |
There was a problem hiding this comment.
Simple past tense is "cast". So castLhsIdentifier would be correct in a grammatical sense. (In case anyone actually cares )
Then again, I'm not a native speaker... ;)
|
@mxcl Correct. The |
|
@jakeheis Added some line comments with suggested refactoring. Great work, and thanks for your contribution! |
|
@mattt! You're alive! :) |
| XCTAssertLessThanOrEqual(v7, v7) | ||
| XCTAssertGreaterThanOrEqual(v7, v7) | ||
| XCTAssertLessThanOrEqual(v8, v8) | ||
| XCTAssertGreaterThanOrEqual(v8, v8) |
There was a problem hiding this comment.
Even if these tests are supplanted by the others, there is no reason to remove them. It’s possible the tests you have written to supplant these have bugs.
Can we get these back?
There was a problem hiding this comment.
Oh sure, I didn't think they were necessary anymore but I can add them back in
There was a problem hiding this comment.
Thanks, I'm sure there aren't bugs with your stuff, but generally with tests I feel more is better and keeping them makes me feel safer.
|
Will merge, if you can squash the history. Thanks. |
Fully conform to Semantic Versioning 2.0.0 spec
|
👍🏻🎆 |
Support command skipping with shouldCommandStart.
This pull request makes the
Versionclass conform fully to the semver spec, fixing https://bugs.swift.org/browse/SR-113.I was unclear about the function of
Specifierin this project, so I did not update that class. I would be happy to do so if need be!