New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in compiler performance test script #323

merged 1 commit into from Feb 6, 2019


None yet
2 participants
Copy link

brentdax commented Feb 6, 2019

Commit 6952162 (which seems to have been pushed directly to master) appears to have inadvertently fixed a prior bug in the run_cperf script which was causing it to save its output file in the wrong place. Unfortunately, it also broke the hack which was copying the file to the right place, causing all compiler performance tests to raise an error right before the comment with the results was posted to Github.

This PR removes the hack, which I believe will at least partially fix compiler performance tests. We may still need to XFAIL a few projects or something, but we should at least get the comment now.

Tagging @shahmishal, because I'm hoping there's a way to test this on the CI before merging it, and if there is I think he'll know how to do it.

Remove hack that’s causing cperf failures
Previously, because we chdir()ed before parsing arguments, the --output argument would be relative to the swift-source-compat-suite directory, which necessitated a hack to write the comment file to the CI-expected path. Commit 6952162 accidentally fixed that bug. Unfortutnately, it also broke the hack, which caused all compiler performance tests to fail. This commit deletes the hack, which should restore correct behavior.

@brentdax brentdax requested a review from shahmishal Feb 6, 2019


This comment has been minimized.

Copy link
Contributor Author

brentdax commented Feb 6, 2019

@swift-ci please test

Copy link

shahmishal left a comment

LGTM! Thanks!

@brentdax brentdax merged commit a37afb2 into apple:master Feb 6, 2019

1 check passed

Swift Source Compatibility Suite on macOS Platform Build finished.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment