Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t SKStressTest certain projects #338

Merged
merged 1 commit into from May 10, 2019

Conversation

Projects
None yet
3 participants
@brentdax
Copy link
Contributor

commented May 10, 2019

The “DNS”, “Guitar”, and “Result” projects are failing to build in SourceKit stress tests, apparently because of a bad interaction between SKStressTester’s swiftc wrapper and SwiftPM. Temporarily remove these projects from stress tester tests.

rdar://problem/50584688

Don’t SKStressTest certain projects
The “DNS”, “Guitar”, and “Result” projects are failing to build, apparently because of a bad interaction between SKStressTester’s swiftc wrapper and SwiftPM. Temporarily remove these projects from stress tester tests.

rdar://problem/50584688

@brentdax brentdax requested a review from shahmishal May 10, 2019

@clackary clackary requested review from nathawes and shahmishal and removed request for shahmishal May 10, 2019

@nathawes
Copy link
Contributor

left a comment

Thanks! I haven't had a chance to look at a proper fix for this yet (had a few other higher priority issues) but should get to it on Monday.

@shahmishal

This comment has been minimized.

@brentdax

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

I think the xfails file gets applied during a later step and wouldn't help here. @nathawes would know for sure, though.

@nathawes

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

Yeah, that's right. That file is for XFAILing SourceKit requests (e.g. code completion) at specific locations in the source files. The problem here isn't an unexpected SourceKit failure but rather some output from the stress tester, which is used in place of swiftc during the build, making the SwiftPM build think the compiler is giving bad output. It passes -parseable-output and I think the stress tester's progress output isn't respecting that.

@brentdax brentdax merged commit ff2b4f1 into apple:master May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.