New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add evolution to shuffle generic where constraints #38

Merged
merged 1 commit into from Feb 5, 2019

Conversation

Projects
None yet
2 participants
@brentdax
Copy link
Contributor

brentdax commented Feb 5, 2019

For instance, “where T: Foo, T: Bar” might become “where T: Bar, T: Foo”. Name mangling should always canonicalize them into the same form; shuffling them should catch any bugs in that code.

Add evolution to shuffle generic where constraints
For instance, “where T: Foo, T: Bar” might become “where T: Bar, T: Foo”. Name mangling should always canonicalize them into the same form; shuffling them should catch any bugs in that code.

@brentdax brentdax requested a review from harlanhaskins Feb 5, 2019


// We cannot use Element: TrailingCommaSyntax here because
// GenericRequirementListSyntax has untyped Syntax elements.
extension BidirectionalCollection where Element == Syntax {

This comment has been minimized.

@harlanhaskins

harlanhaskins Feb 5, 2019

This is clever, I like this.

This comment has been minimized.

@harlanhaskins

harlanhaskins Feb 5, 2019

Er, rather, the line below.

@brentdax brentdax merged commit a789971 into apple:master Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment