New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SwiftEvolve] Update SwiftEvolve for SwiftSyntax API changes #39

Merged
merged 1 commit into from Feb 10, 2019

Conversation

Projects
None yet
2 participants
@akyrtzi
Copy link
Member

akyrtzi commented Feb 10, 2019

I noticed that SwiftEvolve is not built and tested in CI. I will put a PR to fix this but beforehand SwiftEvolve needs to adapt some SwiftSyntax API changes.

@akyrtzi akyrtzi requested a review from brentdax Feb 10, 2019

@akyrtzi

This comment has been minimized.

Copy link
Member Author

akyrtzi commented Feb 10, 2019

Changes are that SyntaxCollections are now only Sequences and to form SourceLocations you need to use SourceLocationConverter.

@brentdax
Copy link
Contributor

brentdax left a comment

LGTM. Thank you!

@brentdax

This comment has been minimized.

Copy link
Contributor

brentdax commented Feb 10, 2019

(Please tag me on the CI change; I'd like to learn what I should have done.)

@akyrtzi akyrtzi merged commit e36becc into apple:master Feb 10, 2019

@akyrtzi akyrtzi deleted the akyrtzi:update-evolve-for-swift-syntax branch Feb 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment