Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-14365] UnresolvedPatternExprSyntax for value bindings #402

Closed
swift-ci opened this issue Mar 16, 2021 · 2 comments
Closed

[SR-14365] UnresolvedPatternExprSyntax for value bindings #402

swift-ci opened this issue Mar 16, 2021 · 2 comments
Labels
bug

Comments

@swift-ci
Copy link
Contributor

@swift-ci swift-ci commented Mar 16, 2021

Previous ID SR-14365
Radar rdar://problem/75536971
Original Reporter bagipro (JIRA User)
Type Bug
Status Closed
Resolution Invalid
Additional Detail from JIRA
Votes 0
Component/s SwiftSyntax
Labels Bug
Assignee None
Priority Medium

md5: 5f059448c94000c1c21afffe354280b3

Issue Description:

Hi,

I tried to parse the following file Signal-iOS/ProfileFetcherJob.swift at master · signalapp/Signal-iOS · GitHub with SwiftSyntax and received multiple errors about unresolved syntax (especially in value bindings)

E.g. the highlighted snippet on the code was marked as UnresolvedPatternExprSyntax. It can be reproduced using code:

        let sourceSyntax: SourceFileSyntax = try SyntaxParser.parse(URL(fileURLWithPath: source))
        class UnresolvedSyntaxVisitor: SyntaxVisitor {
            override func visit(_ node: UnresolvedPatternExprSyntax) -> SyntaxVisitorContinueKind {
                print(node)
                return .skipChildren
            }
        }
        UnresolvedSyntaxVisitor().walk(sourceSyntax)
@typesanitizer
Copy link

@typesanitizer typesanitizer commented Mar 17, 2021

@swift-ci create

@akyrtzi
Copy link
Member

@akyrtzi akyrtzi commented Mar 24, 2021

I think there is a misunderstanding, presence of `UnresolvedPatternExprSyntax` doesn't indicate an error, this is how that particular piece of Swift syntax is represented.

Note that SwiftSyntax only gives you the syntactic structure of the code, it doesn't do any type-checking or name resolving.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 9, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug
Projects
None yet
Development

No branches or pull requests

3 participants