Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-13584] Implement Additional Feedback on New SwiftSyntax Convenience Methods #405

Open
swift-ci opened this issue Sep 22, 2020 · 0 comments
Open

[SR-13584] Implement Additional Feedback on New SwiftSyntax Convenience Methods #405

swift-ci opened this issue Sep 22, 2020 · 0 comments
Labels
bug

Comments

@swift-ci
Copy link
Contributor

@swift-ci swift-ci commented Sep 22, 2020

Previous ID SR-13584
Radar None
Original Reporter vermont42 (JIRA User)
Type Bug
Additional Detail from JIRA
Votes 0
Component/s SwiftSyntax
Labels Bug
Assignee vermont42 (JIRA)
Priority Medium

md5: 14ad515b7c276d59a1dd762b567c3a4b

Issue Description:

After the PR for SR-11580 merged, there was consensus, based on feedback, that the new convenience methods floatingValue and integerValue, should be optional in order to prevent potential crashes. This story is for implementation of this change. There was additional feedback involving naming and genericity. Depending on PR-review feedback, this story may encompass implementation of these changes as well.
@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shahmishal @swift-ci