Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-1112] Wrong suggestion by Fix-it for "if let" unused vars #43725

Closed
Julioacarrettoni mannequin opened this issue Mar 30, 2016 · 9 comments
Closed

[SR-1112] Wrong suggestion by Fix-it for "if let" unused vars #43725

Julioacarrettoni mannequin opened this issue Mar 30, 2016 · 9 comments
Assignees
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself fix-its Feature: diagnostic fix-its good first issue Good for newcomers regression swift 2.2

Comments

@Julioacarrettoni
Copy link
Mannequin

Julioacarrettoni mannequin commented Mar 30, 2016

Previous ID SR-1112
Radar None
Original Reporter @Julioacarrettoni
Type Bug
Status Closed
Resolution Done

Attachment: Download

Environment

swiftlang-703.0.18.1 clang-703.0.29
Xcode: Version 7.3 (7D175)

Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, 2.2Regression, Fix-it, StarterBug
Assignee @Julioacarrettoni
Priority Medium

md5: dd1d34e8d0556c487fd17d81fb2100bc

Issue Description:

When doing a if let bar = foo

@belkadan
Copy link
Contributor

belkadan commented Apr 1, 2016

@jckarter, was this the one you were looking at?

@jckarter
Copy link
Member

jckarter commented Apr 1, 2016

Yeah. This has been fixed in master and the 2.2 branch:

#1961
#1963

@jckarter
Copy link
Member

Julio, this should be fixed in the latest 2.2 snapshot, or the next Xcode seed, if you have a chance to verify.

@swift-ci
Copy link
Collaborator

swift-ci commented May 1, 2016

Comment by Armand Grillet (JIRA)

I am currently using Xcode 7.3 (7D175) and the problem is still here:

@jckarter
Copy link
Member

jckarter commented May 2, 2016

ArmandGrillet (JIRA User) The fix is in 7.3.1 or later.

@jckarter
Copy link
Member

jckarter commented Jun 3, 2016

@Julioacarrettoni or ArmandGrillet (JIRA User), is this fixed in 7.3.1 for you two?

@Julioacarrettoni
Copy link
Mannequin Author

Julioacarrettoni mannequin commented Jun 3, 2016

Yes @jckarter it works perfectly on 7.3.1 (7D1014)!

Should I close the issue?

@jckarter
Copy link
Member

jckarter commented Jun 3, 2016

@Julioacarrettoni Yeah, you can close the issue. Thank you for following up!

@Julioacarrettoni
Copy link
Mannequin Author

Julioacarrettoni mannequin commented Jun 3, 2016

Xcode Version 7.3.1 (7D1014)
It works as intended 👍

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself fix-its Feature: diagnostic fix-its good first issue Good for newcomers regression swift 2.2
Projects
None yet
Development

No branches or pull requests

4 participants