Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-4332] Review interacting with enum discriminator through the witness table #46915

Closed
bob-wilson opened this issue Mar 24, 2017 · 3 comments
Closed

Comments

@bob-wilson
Copy link

bob-wilson commented Mar 24, 2017

Previous ID SR-4332
Radar rdar://problem/31408033
Original Reporter @bob-wilson
Type Task
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Task, AffectsABI, Runtime
Assignee @aschwaighofer
Priority Medium

md5: e442adb143a8f1f5e41463146abc2a5a

Issue Description:

As part of ABI stability, we should review the efficiency of interacting with the enum discriminator through the witness table

@bob-wilson
Copy link
Author

bob-wilson commented Mar 24, 2017

From the ABI Stability manifesto: "The value witness table stores whether a type is trivial and/or bitwise movable, whether there are extra inhabitants and if so how to store and retrieve them, etc. For enums, the value witness table will also provide functionality for interacting with the discriminator. There may be more efficient ways of representing enums that simplify this functionality (or provide a fast path), and that's under investigation"

@bob-wilson
Copy link
Author

bob-wilson commented Apr 3, 2017

@swift-ci create

@aschwaighofer
Copy link
Member

aschwaighofer commented Nov 1, 2017

This is done
#12697

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants