Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-6429] "input file '%0' was modified during the build" should have a valid source location #48979

Open
belkadan opened this issue Nov 18, 2017 · 0 comments

Comments

@belkadan
Copy link
Contributor

@belkadan belkadan commented Nov 18, 2017

Previous ID SR-6429
Radar None
Original Reporter @belkadan
Type Bug
Additional Detail from JIRA
Votes 1
Component/s Compiler
Labels Bug, Driver
Assignee None
Priority Medium

md5: 6e9a603a53b8f28961459f7e82981221

Issue Description:

The Swift compiler checks to see if inputs were modified during the build, and produces an error if they were. This logic is in checkForOutOfDateInputs in Compilation.cpp. However, the diagnostic is emitted with an invalid location (SourceLoc()). In theory, it would make sense to emit it on the first line of the file that changed, as well as any similar diagnostics about a textual input file. However, we don't have a SourceLoc for that file, because we haven't loaded the file into the driver.

We should do something about this.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant