Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-6568] Add option in Swift driver to force output color diagnostics #49118

Open
swift-ci opened this issue Dec 11, 2017 · 5 comments
Open

[SR-6568] Add option in Swift driver to force output color diagnostics #49118

swift-ci opened this issue Dec 11, 2017 · 5 comments

Comments

@swift-ci
Copy link
Collaborator

@swift-ci swift-ci commented Dec 11, 2017

Previous ID SR-6568
Radar None
Original Reporter etc (JIRA User)
Type Improvement
Status Reopened
Resolution
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Improvement, Driver, StarterBug
Assignee None
Priority Medium

md5: 3941be74def4d4fbd9a2a72319675103

relates to:

  • SR-11033 Add option in Swift driver to disable color diagnostics

Issue Description:

Swiftc outputs nice colored text with it's error messages. The swift package manager, when run with 'swift run', outputs uncolored text except for the last line, which it adds to the swiftc output.

I'm running on Ubuntu 16.04.

@belkadan
Copy link
Contributor

@belkadan belkadan commented Dec 11, 2017

The compiler currently has an internal option to force color diagnostics even when output is being captured, but no driver-level option. It would be easy to add, though.

@aciidb0mb3r
Copy link
Member

@aciidb0mb3r aciidb0mb3r commented Dec 11, 2017

I believe this was fixed by apple/swift-package-manager#1391

@belkadan We're using `-Xfrontend -color-diagnostics` to force the color, let me know if that is incorrect.

@belkadan
Copy link
Contributor

@belkadan belkadan commented Dec 11, 2017

Well, SwiftPM shouldn't really rely on frontend options. It's not wrong but it could be more right. Maybe this bug could be used to add support to the compiler driver and get SwiftPM to drop the -Xfrontend?

@aciidb0mb3r
Copy link
Member

@aciidb0mb3r aciidb0mb3r commented Dec 11, 2017

Sure!

@swift-ci
Copy link
Collaborator Author

@swift-ci swift-ci commented Dec 11, 2017

Comment by Charles (JIRA)

Yep! This was fixed by updating to the non-release version of swift.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants