Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-6595] [Forum] importing names with non-Latin characters #49145

Closed
benrimmington opened this issue Dec 12, 2017 · 10 comments
Closed

[SR-6595] [Forum] importing names with non-Latin characters #49145

benrimmington opened this issue Dec 12, 2017 · 10 comments
Labels

Comments

@benrimmington
Copy link
Collaborator

benrimmington commented Dec 12, 2017

Previous ID SR-6595
Radar None
Original Reporter @benrimmington
Type Bug
Status Closed
Resolution Won't Do
Additional Detail from JIRA
Votes 0
Component/s Project Infrastructure
Labels Bug
Assignee najacque (JIRA)
Priority Medium

md5: 5398a0dacb3edbb3f6e30d3deb8af61a

Issue Description:

Names with non-Latin characters are not imported correctly:

http://swift.trydiscourse.com/u?name=1&period=all

They could be transliterated using:

name.applyingTransform(
  StringTransform("Any-Latin; Latin-ASCII; Any-Title"),
  reverse: false)
@belkadan
Copy link
Contributor

belkadan commented Dec 12, 2017

cc najacque (JIRA User)

I don't think it's okay to transliterate people's names…

@swift-ci
Copy link
Collaborator

swift-ci commented Dec 12, 2017

Comment by Nicole Jacque (JIRA)

Let me see if we can resolve this for our final import.

@swift-ci
Copy link
Collaborator

swift-ci commented Dec 12, 2017

Comment by Nicole Jacque (JIRA)

Actually, no, I don't think we should transliterate either....

@benrimmington
Copy link
Collaborator Author

benrimmington commented Dec 13, 2017

There are only 20 users affected, so maybe it's not worth resolving. But you could take the local-part of their email address as a username. This is already the case for https://swift.trydiscourse.com/u/no-reply and a few others.

@swift-ci
Copy link
Collaborator

swift-ci commented Dec 13, 2017

Comment by Nicole Jacque (JIRA)

Maybe we can just offer those people the option of what to do with their username.

@benrimmington
Copy link
Collaborator Author

benrimmington commented Dec 13, 2017

Will everyone be able to change their own username?
e.g. https://swift.trydiscourse.com/u/taylorswift

@swift-ci
Copy link
Collaborator

swift-ci commented Dec 13, 2017

Comment by Nicole Jacque (JIRA)

They will when they sign up. After that they can only change them with admin intervention, I think.

@benrimmington
Copy link
Collaborator Author

benrimmington commented Dec 30, 2017

@@belkadan, the macOS "Users & Groups" prefPane transliterates people's names, when suggesting an account name for their home folder.

@najacque (JIRA User), can this bug report be closed now?

@swift-ci
Copy link
Collaborator

swift-ci commented Jan 2, 2018

Comment by Nicole Jacque (JIRA)

Yep! Closing.

@belkadan
Copy link
Contributor

belkadan commented Jan 2, 2018

Ben, fair point. As long as it's a suggestion or default rather than a forced thing, it would be a reasonable thing to do. It sounds like it's not going to matter too much this time around, though!

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants