Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-6891] Port swift::json (back) to llvm::yaml #49440

Open
belkadan opened this issue Feb 1, 2018 · 0 comments
Open

[SR-6891] Port swift::json (back) to llvm::yaml #49440

belkadan opened this issue Feb 1, 2018 · 0 comments

Comments

@belkadan
Copy link
Contributor

belkadan commented Feb 1, 2018

Previous ID SR-6891
Radar rdar://problem/17879320
Original Reporter @belkadan
Type Task
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Task
Assignee None
Priority Medium

md5: 038b2ebe267da90c2f2f955ae2e66064

Issue Description:

A long time ago Swift needed to serialize some things to JSON. LLVM already had support for serializing YAML, but the system on the other end (something in Xcode, I think) only understood JSON. Since we needed to get things up and running, we just made a clone of llvm::yaml::Output called swift::json::Output that handled the JSON subset and produced JSON-formatted output.

The right thing to do here is for llvm::yaml::Output to have an option flag that says "please use a JSON-compatible serialization". Then swift::json can go away.

This task requires making patches and test cases for upstream LLVM, found at https://llvm.org with patches reviewed at https://reviews.llvm.org. Once that's done, we can cherry-pick that to the current release branch for swift-llvm, then adopt it in Swift.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant