Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-9811] ClangImporter preserves too much sugar #52231

Closed
compnerd opened this issue Jan 30, 2019 · 5 comments
Closed

[SR-9811] ClangImporter preserves too much sugar #52231

compnerd opened this issue Jan 30, 2019 · 5 comments

Comments

@compnerd
Copy link
Collaborator

@compnerd compnerd commented Jan 30, 2019

Previous ID SR-9811
Radar None
Original Reporter @compnerd
Type Sub-task
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Sub-task, Serialization
Assignee @belkadan
Priority Medium

md5: 258052af53af9365ad3ace30b8681746

Parent-Task:

Issue Description:

CoreFoundation (in the swift configuration) has a `_CFThreadRef` type that abstracts over the thread handle type. When that type is imported (for `internal` use) from C into swift (for Foundation), the type sugar is preserved and then re-exposed through the swiftmodule. This results in deserialization failures.

@compnerd
Copy link
Collaborator Author

@compnerd compnerd commented Jan 30, 2019

CC: @belkadan

@belkadan
Copy link
Contributor

@belkadan belkadan commented Jan 30, 2019

This isn't the importer; you'd get the same behavior with a pure Swift module. But we ought to be able to recover here because we also store the underlying types of things.

(We don't want to throw away the sugar entirely because we also use this for debugging, and it'd be weird to see the member variable with the desugared type.)

@belkadan
Copy link
Contributor

@belkadan belkadan commented Jan 30, 2019

I'll see if I can take a look but it's not super high priority because we don't really expect things to disappear from your dependencies like this.

@belkadan
Copy link
Contributor

@belkadan belkadan commented Mar 19, 2019

Oh good, turned out to be easy. #23419

@belkadan
Copy link
Contributor

@belkadan belkadan commented Mar 20, 2019

5.1: #23432

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants