Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-11015] DarwinToolChain should explicitly reject -static-stdlib #53405

Closed
beccadax opened this issue Jun 25, 2019 · 6 comments
Closed

[SR-11015] DarwinToolChain should explicitly reject -static-stdlib #53405

beccadax opened this issue Jun 25, 2019 · 6 comments

Comments

@beccadax
Copy link
Contributor

@beccadax beccadax commented Jun 25, 2019

Previous ID SR-11015
Radar None
Original Reporter @beccadax
Type Task
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Task, Driver, StarterBug
Assignee None
Priority Medium

md5: 00cbbc767c45833f8ad81fcad017d1a2

Issue Description:

We no longer support the -static-stdlib flag on Darwin, so we should reject attempts to use that flag on Darwin builds and remove support for it from toolchains::Darwin.

Doing this properly will require us to add a way for the ToolChain subclass to examine the arguments during validateArgs() so that Darwin can diagnose an error if it sees OPT_static_stdlib. After that, toolchains::Darwin::constructInvocation(StaticLinkJobAction) should be rewritten to assume OPT_static_stdlib is false, and its sibling methods should be audited to see if they should change too. This shouldn't be very difficult, but it's not trivial enough for me to do right away.

@belkadan
Copy link
Contributor

@belkadan belkadan commented Jun 26, 2019

Tagging this as a Starter Bug, but since it may involve a little refactoring it might be better as your second bug fix rather than your first.

@LucianoPAlmeida
Copy link
Collaborator

@LucianoPAlmeida LucianoPAlmeida commented Jul 12, 2019

@belkadan I’d like to start working on this one. Will have a PR coming up soon.

@belkadan
Copy link
Contributor

@belkadan belkadan commented Jul 12, 2019

Great, thanks!

@LucianoPAlmeida
Copy link
Collaborator

@LucianoPAlmeida LucianoPAlmeida commented Jul 14, 2019

Still WIP, but here is the PR #26136

@LucianoPAlmeida
Copy link
Collaborator

@LucianoPAlmeida LucianoPAlmeida commented Aug 11, 2019

Since the PR is merged should this be marked as resolved?

@belkadan
Copy link
Contributor

@belkadan belkadan commented Aug 13, 2019

Yep! The person who fixes an issue moves it to Resolved; the person who reported it moves it to Closed.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants