[SR-11015] DarwinToolChain should explicitly reject -static-stdlib

[beccadax]

Previous ID	SR-11015
Radar	None
Original Reporter	@beccadax
Type	Task
Status	Resolved
Resolution	Done

Additional Detail from JIRA

Votes	0
Component/s	Compiler
Labels	Task, Driver, StarterBug
Assignee	None
Priority	Medium

md5: 00cbbc767c45833f8ad81fcad017d1a2

Issue Description:

We no longer support the -static-stdlib flag on Darwin, so we should reject attempts to use that flag on Darwin builds and remove support for it from toolchains::Darwin.

Doing this properly will require us to add a way for the ToolChain subclass to examine the arguments during validateArgs() so that Darwin can diagnose an error if it sees OPT_static_stdlib. After that, toolchains::Darwin::constructInvocation(StaticLinkJobAction) should be rewritten to assume OPT_static_stdlib is false, and its sibling methods should be audited to see if they should change too. This shouldn't be very difficult, but it's not trivial enough for me to do right away.

[belkadan]

Tagging this as a Starter Bug, but since it may involve a little refactoring it might be better as your second bug fix rather than your first.

[LucianoPAlmeida]

@belkadan I’d like to start working on this one. Will have a PR coming up soon.

[belkadan]

Great, thanks!

[LucianoPAlmeida]

Still WIP, but here is the PR #26136

[LucianoPAlmeida]

Since the PR is merged should this be marked as resolved?

[belkadan]

Yep! The person who fixes an issue moves it to Resolved; the person who reported it moves it to Closed.