Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-12005] Add a smaller test case for AudioKit crash in 5.1 #54440

Closed
typesanitizer opened this issue Jan 10, 2020 · 3 comments
Closed

[SR-12005] Add a smaller test case for AudioKit crash in 5.1 #54440

typesanitizer opened this issue Jan 10, 2020 · 3 comments

Comments

@typesanitizer
Copy link

typesanitizer commented Jan 10, 2020

Previous ID SR-12005
Radar rdar://problem/58861149
Original Reporter @typesanitizer
Type Task
Status Closed
Resolution Won't Do
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Task, StarterBug
Assignee None
Priority Medium

md5: 0f7d7c734f8d4bd8a1f019cc59f4e234

Issue Description:

The AudioKit package was seeing an assertion failure with Swift 5.1 that has been fixed in Swift 5.2. This forum comment: https://forums.swift.org/t/llvm-crashes-in-xcode-11-2-with-build-libraries-for-distribution/30515/4 contains the main function that triggered this issue. It would be good to have a regression test for this in the test suite, even though the problem has been fixed since.

The way to make sure that this test does the thing we expect it to do, is to pick a couple of tags, one swift-5.1-DEVELOPMENT-SNAPSHOT-20yy-mm-dd ("known bad") and similarly for 5.2 ("known good") and manually test that one triggers an assertion failure and another one doesn't. It might take a little bit of trial and error to find two tags that do the expected thing, so it make sense to use two different build directories (using build-script's --build-subdir flag, say) so you're not constantly overwriting the build when switching between tags while working on the PR/reducing the test case.

Please feel free to tag me (varungandhi-apple) for review on GitHub and/or leave a comment here if you need guidance.

@beccadax
Copy link
Contributor

beccadax commented Jan 24, 2020

@swift-ci create

@swift-ci
Copy link
Collaborator

swift-ci commented Jan 11, 2021

Comment by Sachin Vas (JIRA)

theindigamer (JIRA User) I Will be able to pick it up. However, need some guidance.

@typesanitizer
Copy link
Author

typesanitizer commented Jan 11, 2021

At this point, IMO, it's probably way too much work to do this (compared to the benefit). I think we can close this.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants