Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-13976] Improve compiler error message: "partial application of ‘mutating’ method is not allowed" #56371

Closed
mattyoung opened this issue Dec 20, 2020 · 9 comments

Comments

@mattyoung
Copy link

@mattyoung mattyoung commented Dec 20, 2020

Previous ID SR-13976
Radar rdar://problem/72558647
Original Reporter @mattyoung
Type Improvement
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Improvement, DiagnosticsQoI, StarterBug
Assignee abdulajet (JIRA)
Priority Medium

md5: 9f0bf27ca9f784e216381910b63d7486

relates to:

  • SR-15250 Partial application diagnostic is applied incorrectly

Issue Description:

"partial application" is not well known terminology. Please add/change to something clearly indicate what the actual problem is.

See: https://forums.swift.org/t/compile-error-partial-application-of-mutating-method-is-not-allowed-what-is-partial-application/43163/7

@typesanitizer
Copy link

@typesanitizer typesanitizer commented Dec 21, 2020

@swift-ci create

@typesanitizer
Copy link

@typesanitizer typesanitizer commented Jan 11, 2021

Based on https://forums.swift.org/t/compile-error-partial-application-of-mutating-method-is-not-allowed-what-is-partial-application/43163/7, this diagnostic should be changed to something like: "calling a 'mutating' method without an argument list is not allowed".

One needs to change the text for the diagnostic in DiagnosticsSema.def and update the text for the test cases.

Marking this as a StarterBug; feel free to ask questions for clarification here, or tag me for review on GitHub (@ varungandhi-apple).

@swift-ci
Copy link
Collaborator

@swift-ci swift-ci commented Jan 14, 2021

Comment by Abdulhakim Ajetunmobi (JIRA)

I'd take a look at this thanks!

@swift-ci
Copy link
Collaborator

@swift-ci swift-ci commented Sep 13, 2021

Comment by Rajagopalan Gangadharan (JIRA)

Hello theindigamer (JIRA User) it's been long since there is any update regarding this. So could I give it a shot?

@swift-ci
Copy link
Collaborator

@swift-ci swift-ci commented Sep 13, 2021

Comment by Abdulhakim Ajetunmobi (JIRA)

Rajagopalan (JIRA User) not sure reassigning the ticket to yourself before getting a response is the correct form here? I am blocked on the ticket but hoping to still work on it thanks.

@swift-ci
Copy link
Collaborator

@swift-ci swift-ci commented Sep 13, 2021

Comment by Rajagopalan Gangadharan (JIRA)

Oh abdulajet (JIRA User) Sorry about that. go ahead 🙂

@typesanitizer
Copy link

@typesanitizer typesanitizer commented Sep 13, 2021

Active PR under discussion: #35466

Rajagopalan (JIRA User), in the future, you should try to check GitHub first and also wait for the green light from the original assignee (or someone else) before re-assigning the bug to yourself.

@swift-ci
Copy link
Collaborator

@swift-ci swift-ci commented Sep 13, 2021

Comment by Rajagopalan Gangadharan (JIRA)

Yes that was a stupid move from my side really sorry abdulajet (JIRA User) and yes I will make sure I would check properly theindigamer (JIRA User)

@xedin
Copy link
Member

@xedin xedin commented Oct 7, 2021

Fixed by #35466 please use the next available snapshot to verify and close.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants