Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-14137] [C++] Cache failed imports. #56517

Open
zoecarver opened this issue Feb 1, 2021 · 1 comment
Open

[SR-14137] [C++] Cache failed imports. #56517

zoecarver opened this issue Feb 1, 2021 · 1 comment
Labels
C++ Interop Compiler Improvement StarterBug

Comments

@zoecarver
Copy link
Collaborator

@zoecarver zoecarver commented Feb 1, 2021

Previous ID SR-14137
Radar rdar://problem/83405988
Original Reporter @zoecarver
Type Improvement
Status In Progress
Resolution
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Improvement, CxxInterop, StarterBug
Assignee thomassw66 (JIRA)
Priority Medium

md5: e6fd025c695731ad4c62c7d1b91945d7

Issue Description:

Currently, we cache decls after we successfully import them. However, if we fail to import a decl, we should (but currently do not) cache them too. I suspect that this will be a big performance improvement for the compiler because currently, we can't import complex templates or dependent types, which are very expensive to traverse.

This will require fixing a few visitors along the way.
@zoecarver
Copy link
Collaborator Author

@zoecarver zoecarver commented Sep 22, 2021

@swift-ci create

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C++ Interop Compiler Improvement StarterBug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zoecarver