I prepared 2 independent branches with the changes. The default test suite passes after the removal. theindigamer (JIRA User) please let me know whether you consider these removals valid and would like me to open pull requests.
Hmm, that's weird. I think for the first one at least, I thought compiler engineers used it for debugging. Maybe there's a bug somewhere and that variable should actually be used.
For the second one, Clang does support that as an option. So it seems like a bug that it's not being used anywhere. I'll get back to you on Monday/Tuesday on whether these two should be removed or not.
@jirid, the DisableLLVMSLPVectorizer flag can be removed.
The two flags DebugTimeFunctionBodies and DebugTimeExpressionTypeChecking on FrontendOptions should be set when the FrontendOptions are getting parsed (they are not currently set). Then, in ParseTypeCheckerArgs, the type-checker options should copy the value from the FrontendOpts instead of parsing the arguments directly.
Additional Detail from JIRA
From what I can tell, it isn't being used anywhere; we've been using the swiftcall convention for several years now.
Remove enable_swiftcall from FrontendOptions.td
Remove UseSwiftCall from FrontendOptions.h and other places it is mentioned.
This shouldn't require any new test cases.
The text was updated successfully, but these errors were encountered: