test.swift:4:1: error: 'case' label in a 'switch' should have at least one executable statement
test.swift:5:1: error: 'default' label in a 'switch' should have at least one executable statement
Given that these are errors, it seems sensible (to me) to change the wording from `should` to `must`.
The text was updated successfully, but these errors were encountered:
Hello theindigamer (JIRA User) I am just trying to resolve this SR as my first contribution to Swift compiler. I've changed `DiagnosticsParse.def` file and the test file `switch.swift` in `test/Parse` folder, what is the meaning of the `8-8= break` by the way?
What else should I make changes to finish this one? How can I test the change locally?
The M-N=blah syntax means that there is a fix-it to replace the text for column numbers in the range M ..< N with the text blah. So with 8-8= break, it would add a break at the position (preceded by a space).
I don't think there should be any changes needed apart from the test cases and the diagnostic file. In case there are other tests which also have this diagnostic, you may see failures there too, so you'll need to update the text.