[SR-15053] Improve diagnostics on type errors involving arithmetic expressions

[mattyoung]

Previous ID	SR-15053
Radar	rdar://problem/81774103
Original Reporter	@mattyoung
Type	Improvement
Status	Resolved
Resolution	Done

Additional Detail from JIRA

Votes	0
Component/s	Compiler
Labels	Improvement, DiagnosticsQoI, TypeChecker
Assignee	@LucianoPAlmeida
Priority	Medium

md5: d9ae95cc29673bbed4806ff8fa1380ca

Issue Description:

For the following test, I wish the compiler error say the actual problem:

"Cannot apply / on or between Numeric"

func fooAAA<T : Numeric>(_ a: T, _ b: T) -> T {
    // this results in two compile errors, first is correct, second should not be:
    // Binary operator '/' cannot be applied to operands of type 'T' and 'Int'    <=== this error is correct
    // Binary operator '+' cannot be applied to two 'T' operands    <=== !!! but this should not be an error!!!
    (a + b) / 2
}

// this version returns void, now the same expression give different compiler error
func fooDDD<T : Numeric>(_ a: T, _ b: T) {
    // same expression but give different error:
    // Cannot convert value of type 'T' to expected argument type 'Int'
    // Replace '(a + b)' with 'Int((a + b))'
    // so the compiler give totally different diagnostic for the same expression as above
    (a + b) / 2
}

Breaking the expression up produce better error:

let sum = a + b
return sum / 2  // Binary operator '/' cannot be applied to operands of type 'T' and 'Int'

see: https://forums.swift.org/t/unhelpful-inconsistent-compiler-error/51092

[typesanitizer]

@swift-ci create

[LucianoPAlmeida]

Fixed on main by #39220
@mattyoung Can you please verify on next available snapshot and close? Thanks =]