New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Add dictionary overloads for merging methods #10156

Merged
merged 1 commit into from Jun 7, 2017

Conversation

Projects
None yet
2 participants
@natecook1000
Member

natecook1000 commented Jun 7, 2017

This is a cherry pick of #10113.

  • Explanation: Adds dictionary-specific overloads of the merge(_:uniquingKeysWith:) and merging(_:uniquingKeysWith:) so that dictionaries can be passed.
  • Scope: This adds two type-specific overloads to existing generic methods on Dictionary.
  • Radar/SR: rdar://problem/32352586
  • Risk: Low
  • Testing: Added unit tests that verify dictionaries and sequences of tuples can be used in merging methods. PR passed unit and compatibility checks.
Merge pull request #10113 from natecook1000/nc-dict-tuples
[stdlib] Add dictionary overloads for merging methods
@natecook1000

This comment has been minimized.

Show comment
Hide comment
@natecook1000

natecook1000 Jun 7, 2017

Member

@swift-ci Please test

Member

natecook1000 commented Jun 7, 2017

@swift-ci Please test

@airspeedswift airspeedswift merged commit a55c467 into apple:swift-4.0-branch Jun 7, 2017

4 checks passed

Swift Test Linux Platform 9910 tests run, 0 skipped, 0 failed.
Details
Swift Test Linux Platform (smoke test)
Details
Swift Test OS X Platform 49805 tests run, 0 skipped, 0 failed.
Details
Swift Test OS X Platform (smoke test)
Details

@natecook1000 natecook1000 deleted the natecook1000:nc4-dict-tuples branch Jun 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment