New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .zero convenience static vars for UIEdgeInsets and UIOffset #1323

Merged
merged 3 commits into from Mar 25, 2016

Conversation

Projects
None yet
4 participants
@neilkimmett
Contributor

neilkimmett commented Feb 16, 2016

Using UIEdgeInsetsZero instead of UIEdgeInsets.zero was annoying.
Copied the style from '/stdlib/public/SDK/CoreGraphics/CoreGraphics.swift'

I think this is the logical place to put all the bits. Was unsure whether to use the print(…) … // CHECK: … style tests or just an assert so I did both.

Add .zero convenience static vars for UIEdgeInsets and UIOffset
Using UIEdgeInsetsZero instead of UIEdgeInsets.zero was annoying.
Copied the style from '/stdlib/public/SDK/CoreGraphics/CoreGraphics.swift'

@jrose-apple jrose-apple self-assigned this Feb 16, 2016

@jrose-apple

This comment has been minimized.

Show comment
Hide comment
@jrose-apple

jrose-apple Feb 16, 2016

Member

Changes to the overlays have to go through the framework teams at Apple. I'll talk to them internally and report back to you.

Member

jrose-apple commented Feb 16, 2016

Changes to the overlays have to go through the framework teams at Apple. I'll talk to them internally and report back to you.

@jrose-apple

This comment has been minimized.

Show comment
Hide comment
@jrose-apple

jrose-apple Feb 16, 2016

Member

For the tests, I would just stick to print for now, since that's what the rest of the file is doing. The real right answer is to convert the test to use StdlibUnittest, but that can be done separately.

Member

jrose-apple commented Feb 16, 2016

For the tests, I would just stick to print for now, since that's what the rest of the file is doing. The real right answer is to convert the test to use StdlibUnittest, but that can be done separately.

@neilkimmett

This comment has been minimized.

Show comment
Hide comment
@neilkimmett

neilkimmett Feb 17, 2016

Contributor

@regnerjr nope you're absolutely right, that's a copypaste error 🙊

Contributor

neilkimmett commented Feb 17, 2016

@regnerjr nope you're absolutely right, that's a copypaste error 🙊

@tkremenek

This comment has been minimized.

Show comment
Hide comment
@tkremenek

tkremenek Mar 15, 2016

Member

@swift-ci Please test

Member

tkremenek commented Mar 15, 2016

@swift-ci Please test

@neilkimmett

This comment has been minimized.

Show comment
Hide comment
@neilkimmett

neilkimmett Mar 15, 2016

Contributor

@tkremenek The CI seems to have failed on
Assertion failed: (conformance && "Missing String conformation to _ObjectiveCBridgeable?"), function emitCBridgedToNativeValue, file /Users/buildnode/jenkins/workspace/swift-PR-osx/swift/lib/SILGen/SILGenBridging.cpp, line 672.

Is this something I've broken or is it unrelated? A cursory bit of digging suggests the latter but I'm not sure 😕

Contributor

neilkimmett commented Mar 15, 2016

@tkremenek The CI seems to have failed on
Assertion failed: (conformance && "Missing String conformation to _ObjectiveCBridgeable?"), function emitCBridgedToNativeValue, file /Users/buildnode/jenkins/workspace/swift-PR-osx/swift/lib/SILGen/SILGenBridging.cpp, line 672.

Is this something I've broken or is it unrelated? A cursory bit of digging suggests the latter but I'm not sure 😕

@jrose-apple

This comment has been minimized.

Show comment
Hide comment
@jrose-apple

jrose-apple Mar 21, 2016

Member

Okay, UIKit has approved this change! (Sorry for the turnaround time.) I'll trigger the tests again.

Member

jrose-apple commented Mar 21, 2016

Okay, UIKit has approved this change! (Sorry for the turnaround time.) I'll trigger the tests again.

@jrose-apple

This comment has been minimized.

Show comment
Hide comment
@jrose-apple

jrose-apple Mar 21, 2016

Member

@swift-ci Please test

Member

jrose-apple commented Mar 21, 2016

@swift-ci Please test

@jrose-apple jrose-apple merged commit d9596ab into apple:master Mar 25, 2016

2 checks passed

Swift Test Linux Platform Build finished. 8027 tests run, 0 skipped, 0 failed.
Details
Swift Test OS X Platform Build finished. 32268 tests run, 0 skipped, 0 failed.
Details
@jrose-apple

This comment has been minimized.

Show comment
Hide comment
@jrose-apple

jrose-apple Mar 25, 2016

Member

Thanks, Neil!

Member

jrose-apple commented Mar 25, 2016

Thanks, Neil!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment