Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class resilience part 11 #13689

Merged
merged 3 commits into from Jan 4, 2018

Conversation

Projects
None yet
3 participants
@slavapestov
Copy link
Member

slavapestov commented Jan 3, 2018

Some code review feedback from @rjmccall (but not everything -- still working on it), as well as a fix for a problem with method overrides that I missed during testing when constant-folding -enable-class-resilience to true.

@slavapestov slavapestov force-pushed the slavapestov:class-resilience-part-11 branch 2 times, most recently Jan 3, 2018

@slavapestov slavapestov requested a review from rjmccall Jan 4, 2018

@rjmccall
Copy link
Member

rjmccall left a comment

LGTM.

@slavapestov slavapestov force-pushed the slavapestov:class-resilience-part-11 branch Jan 4, 2018

slavapestov added some commits Dec 23, 2017

IRGen: Preliminary implementation of resilient method overrides
This is not the final mechanism, because it does not allow
re-ordering superclass methods, but at least it works if
you don't do that.

@slavapestov slavapestov force-pushed the slavapestov:class-resilience-part-11 branch to f18ef54 Jan 4, 2018

@slavapestov

This comment has been minimized.

Copy link
Member Author

slavapestov commented Jan 4, 2018

@swift-ci Please test

@slavapestov

This comment has been minimized.

Copy link
Member Author

slavapestov commented Jan 4, 2018

@swift-ci Please test source compatibility

@swift-ci

This comment has been minimized.

Copy link
Contributor

swift-ci commented Jan 4, 2018

Build failed
Swift Test Linux Platform
Git Sha - 13f9401135b4e72fb186dc213c8c74cf37b655c5

@swift-ci

This comment has been minimized.

Copy link
Contributor

swift-ci commented Jan 4, 2018

Build failed
Swift Test OS X Platform
Git Sha - 13f9401135b4e72fb186dc213c8c74cf37b655c5

@slavapestov

This comment has been minimized.

Copy link
Member Author

slavapestov commented Jan 4, 2018

@swift-ci Please test source compatibility

1 similar comment
@slavapestov

This comment has been minimized.

Copy link
Member Author

slavapestov commented Jan 4, 2018

@swift-ci Please test source compatibility

@slavapestov

This comment has been minimized.

Copy link
Member Author

slavapestov commented Jan 4, 2018

Source compat failure is fixed in #13711.

@slavapestov slavapestov merged commit 38be0b7 into apple:master Jan 4, 2018

4 of 5 checks passed

Swift Source Compatibility Suite on macOS Platform Build finished.
Details
Swift Test Linux Platform 10667 tests run, 0 skipped, 0 failed.
Details
Swift Test Linux Platform (smoke test)
Details
Swift Test OS X Platform 53455 tests run, 0 skipped, 0 failed.
Details
Swift Test OS X Platform (smoke test)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.