Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code duplication in inspecting dylibs #1466

Merged
merged 1 commit into from Mar 15, 2016

Conversation

@tinysun212
Copy link
Contributor

@tinysun212 tinysun212 commented Feb 27, 2016

What's in this pull request?

MetadataLookup.cpp and ProtocolConformance.cpp has same part for inspecting dynamic libraries.
This PR remove some duplicated code for ELF and Cygwin.
The common code exist in one file and other uses it.
This uses the argument passing to callback in Linux/Cygwin and not applied to OS X.

Resolved bug number: N/A


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the github user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
OS X platform @swift-ci Please test OS X platform
Linux platform @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

MetadataLookup.cpp and ProtocolConformance.cpp has same part for inspecting dynamic libraries.
The common code exist in one file and other uses it.
This uses the argument passing to callback in Linux/Cygwin and not applied to OS X.
@tinysun212 tinysun212 mentioned this pull request Feb 27, 2016
@gottesmm
Copy link
Member

@gottesmm gottesmm commented Feb 27, 2016

@swift-ci Please test

@modocache
Copy link
Collaborator

@modocache modocache commented Feb 28, 2016

Excellent. Thanks for continuing to work on this, @tinysun212, it should be very useful for #1442 as well. 👍

@tkremenek
Copy link
Member

@tkremenek tkremenek commented Mar 9, 2016

@swift-ci Please test

@tkremenek tkremenek self-assigned this Mar 9, 2016
@jckarter
Copy link
Member

@jckarter jckarter commented Mar 14, 2016

@tinysun212 LGTM, thanks @tinysun212 !

tkremenek added a commit that referenced this pull request Mar 15, 2016
Refactor code duplication in inspecting dylibs
@tkremenek tkremenek merged commit 2ded9fe into apple:master Mar 15, 2016
2 checks passed
2 checks passed
Swift Test Linux Platform Build finished. 7988 tests run, 0 skipped, 0 failed.
Details
Swift Test OS X Platform Build finished. 32116 tests run, 0 skipped, 0 failed.
Details
@tinysun212 tinysun212 deleted the tinysun212:pr-common-inspect-dylib branch Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.