Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
SR-106: New floating-point `description` implementation #15474
This replaces the current implementation of
Unlike the earlier code based on
With the new code, the REPL generally prints the values you would expect.
In comparison, the previous implementation routinely prints extraneous digits for
Of course, this only changes how the floating-point numbers are printed. The actual parsing, storage, and arithmetic operations are unaffected and are still subject to the same rounding issues common to all floating-point arithmetic.
About the Algorithm
The implementation is:
The graph below compares the new code (in green) to the performance of three other
I just noticed the bottom label got cut off on the graph. The horizontal axis is
Build comment file:
No Changes (410)
No Changes (403)
Looks like you need to update
To iterate quicker, you can run
edit: more details
Seems the Linux failure here might be a clang bug?
@jckarter any idea why there would be the following failure on Linux?
Now the Linux build fails at a different point: