/swift

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gender-neutral language #162

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
@pcbro
Contributor

pcbro commented Dec 4, 2015

Fixes inconsiderate comment
lib/Sema/TypeCheckDecl.cpp
@@ -2930,7 +2930,7 @@ class DeclChecker : public DeclVisitor<DeclChecker> {
if (!IsSecondPass) {
for (unsigned i = 0, e = PBD->getNumPatternEntries(); i != e; ++i) {
// Type check each VarDecl in that his PatternBinding handles.
// Type check each VarDecl in that their PatternBinding handles.

This comment has been minimized.

Show comment
Hide comment
@cwillmor

cwillmor Dec 4, 2015

Member

I think this is supposed to say "Type check each VarDecl that this PatternBinding handles.".
Copy URL
@cwillmor

cwillmor Dec 4, 2015

Member

I think this is supposed to say "Type check each VarDecl that this PatternBinding handles.".

This comment has been minimized.

Show comment
Hide comment
@jeeftor

jeeftor Dec 4, 2015

@cwillmor good point. I think this is a bad PR
Copy URL
@jeeftor

jeeftor Dec 4, 2015

@cwillmor good point. I think this is a bad PR

This comment has been minimized.

Show comment
Hide comment
@tangentfairy

tangentfairy Dec 4, 2015

I think this is hilarious but @cwillmor is right and it is just a typo. We have to appreciate @pcbro's sense of humour though 😛
Copy URL
@tangentfairy

tangentfairy Dec 4, 2015

I think this is hilarious but @cwillmor is right and it is just a typo. We have to appreciate @pcbro's sense of humour though 😛

This comment has been minimized.

Show comment
Hide comment
@Shirk

Shirk Dec 4, 2015

@tangentfairy - I'm not sure it's humor at all.. look here #165
Copy URL
@Shirk

Shirk Dec 4, 2015

@tangentfairy - I'm not sure it's humor at all.. look here #165

This comment has been minimized.

Show comment
Hide comment
@jcfrancisco

jcfrancisco Dec 4, 2015

@Shirk The user @pcbro is definitely trying to get a rise out of someone -- the account is fashioned after the character "PC Principal" in South Park, who's somewhat of a caricature of an politically correct person. This doesn't mean the PRs should be ignored, but the intent behind them is pretty clear to me.
Copy URL
@jcfrancisco

jcfrancisco Dec 4, 2015

@Shirk The user @pcbro is definitely trying to get a rise out of someone -- the account is fashioned after the character "PC Principal" in South Park, who's somewhat of a caricature of an politically correct person. This doesn't mean the PRs should be ignored, but the intent behind them is pretty clear to me.
@bprzemyslaw

This comment has been minimized.

Show comment
Hide comment
@bprzemyslaw

bprzemyslaw Dec 4, 2015

It appears to me somebody just wants to become a contributor really bad.

bprzemyslaw commented Dec 4, 2015

It appears to me somebody just wants to become a contributor really bad.
@jckarter

This comment has been minimized.

Show comment
Hide comment
@jckarter

jckarter Dec 4, 2015

Member

I think @cwillmor's right that the typo is different. Eliminating pointless gendered language in general is welcome though. (Comments like "get a grip", "this doesn't matter", and other silencing tactics are disrespectful and definitely aren't welcome.)
Member

jckarter commented Dec 4, 2015

I think @cwillmor's right that the typo is different. Eliminating pointless gendered language in general is welcome though. (Comments like "get a grip", "this doesn't matter", and other silencing tactics are disrespectful and definitely aren't welcome.)
@tangentfairy

This comment has been minimized.

Show comment
Hide comment
@tangentfairy

tangentfairy Dec 4, 2015

Completely agree with you @jckarter 😄

tangentfairy commented Dec 4, 2015

Completely agree with you @jckarter 😄

mightydeveloper added a commit to mightydeveloper/swift that referenced this pull request Dec 4, 2015

@mightydeveloper
Fixed typo. 
Handled issue #162
a6f590c

mightydeveloper added a commit to mightydeveloper/swift that referenced this pull request Dec 4, 2015

@mightydeveloper
Fixed typo. 
Handled issue #162

Fixed typos

Fixed typo.
Handled issue #162
07531c4

mightydeveloper added a commit to mightydeveloper/swift that referenced this pull request Dec 4, 2015

@mightydeveloper
Fixed typo. 
Handled issue #162
squashed multiple typo fix commits
134eb63
@AdamHess

This comment has been minimized.

Show comment
Hide comment
@AdamHess

AdamHess Dec 4, 2015

@pcbro is just being a troll

AdamHess commented Dec 4, 2015

@pcbro is just being a troll
@benlangmuir

This comment has been minimized.

Show comment
Hide comment
@benlangmuir

benlangmuir Dec 4, 2015

Member

This was fixed per @cwillmor's suggestion as part of #186.
Member

benlangmuir commented Dec 4, 2015

This was fixed per @cwillmor's suggestion as part of #186.

@benlangmuir benlangmuir closed this Dec 4, 2015

@jckarter

This comment has been minimized.

Show comment
Hide comment
@jckarter

jckarter Dec 4, 2015

Member

@AdamHess Remember Poe's law. If their contribution is helpful and aligned with our goals, who's really getting trolled?
Member

jckarter commented Dec 4, 2015

@AdamHess Remember Poe's law. If their contribution is helpful and aligned with our goals, who's really getting trolled?
@AdamHess

This comment has been minimized.

Show comment
Hide comment
@AdamHess

AdamHess Dec 4, 2015

@jckarter this is not @pcbro first pull request to this repo. Additionally, it's NOT helpful it's a typo. @pcbro is not being helpful by pointing out typos but making uneducated fun of various programming terminology and practices see earlier pull request: #165 I cant beleive that the project maintainers even merged the request.

AdamHess commented Dec 4, 2015

@jckarter this is not @pcbro first pull request to this repo. Additionally, it's NOT helpful it's a typo. @pcbro is not being helpful by pointing out typos but making uneducated fun of various programming terminology and practices see earlier pull request: #165 I cant beleive that the project maintainers even merged the request.
@AdamHess

This comment has been minimized.

Show comment
Hide comment
@AdamHess

AdamHess Dec 4, 2015

God I just realized @jckarter is working in cahoots with @pcbro ... so its basically apple trolling the dev community. Good job.

AdamHess commented Dec 4, 2015

God I just realized @jckarter is working in cahoots with @pcbro ... so its basically apple trolling the dev community. Good job.
@hirad

This comment has been minimized.

Show comment
Hide comment
@hirad

hirad Dec 4, 2015

@AdamHess @pcbro's entire account is referencing a South Park parody of SJWs. I think you're right. I don't understand why he's taken seriously.

hirad commented Dec 4, 2015

@AdamHess @pcbro's entire account is referencing a South Park parody of SJWs. I think you're right. I don't understand why he's taken seriously.

lowell added a commit to lowell/swift that referenced this pull request Dec 4, 2015

@mightydeveloper @lowell
Fixed typo. 
Handled issue #162
squashed multiple typo fix commits
3753963
@steveklabnik

This comment has been minimized.

Show comment
Hide comment
@steveklabnik

steveklabnik Dec 5, 2015

Contributor

@jckarter exactly, 👍
Contributor

steveklabnik commented Dec 5, 2015

@jckarter exactly, 👍
@AdamHess

This comment has been minimized.

Show comment
Hide comment
@AdamHess

AdamHess Dec 5, 2015

@hirad I'm well aware of it. The problem is that his pull requests are being accepted and merged into the master branch.

AdamHess commented Dec 5, 2015

@hirad I'm well aware of it. The problem is that his pull requests are being accepted and merged into the master branch.
@jckarter

This comment has been minimized.

Show comment
Hide comment
@jckarter

jckarter Dec 5, 2015

Member

I think we're done here.
Member

jckarter commented Dec 5, 2015

I think we're done here.

@apple apple locked and limited conversation to collaborators Dec 5, 2015

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.