New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRGen: Imported protocol extensions #1938

Merged
merged 2 commits into from Mar 31, 2016

Conversation

Projects
None yet
1 participant
@jckarter
Member

jckarter commented Mar 29, 2016

Fix crashes when calling C functions imported as protocol extension methods.

@jckarter

This comment has been minimized.

Show comment
Hide comment
@jckarter

jckarter Mar 29, 2016

Member

@swift-ci Please test

Member

jckarter commented Mar 29, 2016

@swift-ci Please test

@jckarter

This comment has been minimized.

Show comment
Hide comment
@jckarter

jckarter Mar 30, 2016

Member

@swift-ci Please test Linux

Member

jckarter commented Mar 30, 2016

@swift-ci Please test Linux

@jckarter

This comment has been minimized.

Show comment
Hide comment
@jckarter

jckarter Mar 30, 2016

Member

@swift-ci Please test

Member

jckarter commented Mar 30, 2016

@swift-ci Please test

jckarter added some commits Mar 29, 2016

IRGen: Ignore generic parameters of SIL @convention(c) types.
That's the lowering we get for C functions imported as members of protocols.
@jckarter

This comment has been minimized.

Show comment
Hide comment
@jckarter

jckarter Mar 30, 2016

Member

@swift-ci Please test

Member

jckarter commented Mar 30, 2016

@swift-ci Please test

@jckarter jckarter merged commit b8aa737 into apple:master Mar 31, 2016

2 checks passed

Swift Test Linux Platform Build finished. 8069 tests run, 0 skipped, 0 failed.
Details
Swift Test OS X Platform Build finished. 32440 tests run, 0 skipped, 0 failed.
Details

@jckarter jckarter deleted the jckarter:irgen-imported-protocol-extensions branch Mar 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment