New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SR-8649: Range types conform to Codable #19532

Merged
merged 8 commits into from Jan 14, 2019

Conversation

Projects
None yet
7 participants
@dlbuckley
Copy link
Contributor

dlbuckley commented Sep 25, 2018

Overview

Conform Range, ClosedRange, PartialRangeUpTo, PartialRangeThrough and PartialRangeFrom to Codable.

Bug Report

SR-8649

Forum Thread

Range conform to Codable

Proposal Amendment PR

Swift Evolution PR #915

@xwu
Copy link
Collaborator

xwu left a comment

Nice additions! Some brief comments below.

Show resolved Hide resolved stdlib/public/core/ClosedRange.swift Outdated
Show resolved Hide resolved stdlib/public/core/ClosedRange.swift Outdated
Show resolved Hide resolved stdlib/public/core/Range.swift Outdated
@xwu

This comment has been minimized.

Copy link
Collaborator

xwu commented Sep 25, 2018

@swift-ci please smoke test

@parkera

This comment has been minimized.

Copy link
Member

parkera commented Oct 22, 2018

Where did we end up on this one?

@dlbuckley

This comment has been minimized.

Copy link
Contributor Author

dlbuckley commented Oct 29, 2018

@parkera Sorry, life got in the way with making the required changes to this PR. I will make the required changes today and try to add in the tests for this (but it's still something I need to investigate).

@parkera

This comment has been minimized.

Copy link
Member

parkera commented Oct 29, 2018

Awesome, thanks!

@dlbuckley

This comment has been minimized.

Copy link
Contributor Author

dlbuckley commented Oct 31, 2018

@parkera I've made the changes and added the tests in what I'm assuming to be the right place.

@parkera

This comment has been minimized.

Copy link
Member

parkera commented Nov 5, 2018

Thanks @dlbuckley, this looks good to me.

Show resolved Hide resolved stdlib/public/core/ClosedRange.swift Outdated
Show resolved Hide resolved stdlib/public/core/Range.swift Outdated
Show resolved Hide resolved stdlib/public/core/Range.swift Outdated
Show resolved Hide resolved stdlib/public/core/Range.swift Outdated
Show resolved Hide resolved stdlib/public/core/Range.swift Outdated
@moiseev

This comment has been minimized.

Copy link
Member

moiseev commented on 6ef7cca Dec 3, 2018

👍

@moiseev

This comment has been minimized.

Copy link
Member

moiseev commented Dec 13, 2018

@swift-ci Please test

@swift-ci

This comment has been minimized.

Copy link
Contributor

swift-ci commented Dec 13, 2018

Build failed
Swift Test Linux Platform
Git Sha - 6ef7cca

@moiseev

This comment has been minimized.

Copy link
Member

moiseev commented Dec 14, 2018

@swift-ci Please test Linux platform

@moiseev

This comment has been minimized.

Copy link
Member

moiseev commented Dec 19, 2018

@swift-ci Please Test Source Compatibility

@moiseev moiseev merged commit 3b6c6cc into apple:master Jan 14, 2019

6 checks passed

Swift Source Compatibility Suite on macOS Platform (Debug)
Details
Swift Source Compatibility Suite on macOS Platform (Release)
Details
Swift Test Linux Platform 11563 tests run, 10422 skipped, 0 failed.
Details
Swift Test Linux Platform (smoke test)
Details
Swift Test OS X Platform 58005 tests run, 2485 skipped, 0 failed.
Details
Swift Test OS X Platform (smoke test)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment