New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Index] Fully index Swift Keypaths referencing @objc properties #19938

Merged
merged 6 commits into from Oct 23, 2018

Conversation

Projects
None yet
2 participants
@rockbruno
Contributor

rockbruno commented Oct 18, 2018

From SR-9039: Swift keypaths index perfectly when used against pure Swift types, but were being ignored when the keypath referenced an objc property.

Weirdly enough, the solution seemed to be to simply not stop visiting the keypath when the objc string is retrieved... #keyPath() keypaths appear to be unaffected by this change, so I hope this is the right solution.

@rockbruno

This comment has been minimized.

Contributor

rockbruno commented Oct 22, 2018

@akyrtzi akyrtzi self-requested a review Oct 22, 2018

@akyrtzi

Good catch! This looks like the right fix to me.

@akyrtzi

This comment has been minimized.

Member

akyrtzi commented Oct 23, 2018

@swift-ci smoke test

@akyrtzi akyrtzi merged commit e089f2a into apple:master Oct 23, 2018

2 checks passed

Swift Test Linux Platform (smoke test)
Details
Swift Test OS X Platform (smoke test)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment