Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the integer-literal type from Int2048 to IntLiteral #20208

Merged
merged 1 commit into from Nov 1, 2018

Conversation

Projects
None yet
2 participants
@rjmccall
Copy link
Member

commented Nov 1, 2018

Part of SR-290 / rdar://25100871.

The type was implemented in #20200.
Runtime support was added in #20177.

@rjmccall

This comment has been minimized.

Copy link
Member Author

commented Nov 1, 2018

@swift-ci Please test.

@rjmccall rjmccall requested a review from DougGregor Nov 1, 2018

@swift-ci

This comment has been minimized.

Copy link
Contributor

commented Nov 1, 2018

Build failed
Swift Test OS X Platform
Git Sha - 8a26656ee4f8e843757f598b0b88de7e72911037

@rjmccall rjmccall force-pushed the rjmccall:builtin-integer-literal branch to abdba1d Nov 1, 2018

@rjmccall

This comment has been minimized.

Copy link
Member Author

commented Nov 1, 2018

@swift-ci Please test.

@rjmccall

This comment has been minimized.

Copy link
Member Author

commented Nov 1, 2018

@swift-ci Please test source compatibility

@swift-ci

This comment has been minimized.

Copy link
Contributor

commented Nov 1, 2018

Build failed
Swift Test Linux Platform
Git Sha - 8a26656ee4f8e843757f598b0b88de7e72911037

@swift-ci

This comment has been minimized.

Copy link
Contributor

commented Nov 1, 2018

Build failed
Swift Test OS X Platform
Git Sha - 8a26656ee4f8e843757f598b0b88de7e72911037

@rjmccall

This comment has been minimized.

Copy link
Member Author

commented Nov 1, 2018

@swift-ci Please test OS X.

@rjmccall

This comment has been minimized.

Copy link
Member Author

commented Nov 1, 2018

@swift-ci Please smoke benchmark.

@rjmccall

This comment has been minimized.

Copy link
Member Author

commented Nov 1, 2018

@swift-ci Please benchmark

@rjmccall

This comment has been minimized.

Copy link
Member Author

commented Nov 1, 2018

Okay, all those source-compatibility failures are there on the main bots.

@swift-ci

This comment has been minimized.

Copy link
Contributor

commented Nov 1, 2018

Build comment file:

Performance: -O

TEST OLD NEW DELTA RATIO
Improvement
CStringLongAscii 3526 3282 -6.9% 1.07x

Performance: -Osize

TEST OLD NEW DELTA RATIO
Improvement
CStringLongAscii 3528 3278 -7.1% 1.08x

Performance: -Onone

TEST OLD NEW DELTA RATIO
Improvement
DictionaryCompactMapValuesOfCastValue 123656 97884 -20.8% 1.26x
WordCountUniqueASCII 8167 6935 -15.1% 1.18x
ArrayOfGenericPOD2 1236 1067 -13.7% 1.16x (?)
ArrayOfPOD 858 782 -8.9% 1.10x
MonteCarloE 1231361 1144667 -7.0% 1.08x
MonteCarloPi 5656060 5279794 -6.7% 1.07x

Code size: Swift libraries

TEST OLD NEW DELTA RATIO
Improvement
libswiftCore.dylib 3911680 3813376 -2.5% 1.03x
How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false alarms. Unexpected regressions which are marked with '(?)' are probably noise. If you see regressions which you cannot explain you can try to run the benchmarks again. If regressions still show up, please consult with the performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

@rjmccall rjmccall merged commit 73589ec into apple:master Nov 1, 2018

5 of 6 checks passed

Swift Source Compatibility Suite on macOS Platform (Debug)
Details
Swift Source Compatibility Suite on macOS Platform (Release)
Details
Swift Test Linux Platform 11426 tests run, 10310 skipped, 0 failed.
Details
Swift Test Linux Platform (smoke test)
Details
Swift Test OS X Platform 57315 tests run, 2412 skipped, 0 failed.
Details
Swift Test OS X Platform (smoke test)
Details

@rjmccall rjmccall deleted the rjmccall:builtin-integer-literal branch Nov 1, 2018

@swift-ci

This comment has been minimized.

Copy link
Contributor

commented Nov 1, 2018

Build comment file:

Performance: -O

TEST OLD NEW DELTA RATIO
Regression
StringHashing_abnormal 1311 1430 +9.1% 0.92x
CStringLongAscii 3282 3540 +7.9% 0.93x
Improvement
UTF8Decode_InitFromBytes 1387 1185 -14.6% 1.17x
StringWordBuilder 1887 1739 -7.8% 1.09x (?)
FloatingPointPrinting_Float_description_small 5561 5173 -7.0% 1.08x

Performance: -Osize

TEST OLD NEW DELTA RATIO
Regression
StringHashing_abnormal 1305 1434 +9.9% 0.91x
CStringLongAscii 3280 3534 +7.7% 0.93x

Performance: -Onone

TEST OLD NEW DELTA RATIO
Regression
ArrayOfGenericPOD2 1066 1236 +15.9% 0.86x (?)
UTF8Decode_InitDecoding_ascii 843 927 +10.0% 0.91x
ArrayOfPOD 785 861 +9.7% 0.91x (?)
CStringLongAscii 3367 3638 +8.0% 0.93x
Improvement
CharIteration_tweet_unicodeScalars_Backwards 624239 498797 -20.1% 1.25x
CharIteration_chinese_unicodeScalars_Backwards 229660 190255 -17.2% 1.21x
CharIteration_russian_unicodeScalars_Backwards 251977 209430 -16.9% 1.20x
CharIteration_japanese_unicodeScalars_Backwards 362111 301470 -16.7% 1.20x
CharIteration_korean_unicodeScalars_Backwards 292831 243863 -16.7% 1.20x
CharIteration_punctuated_unicodeScalars_Backwards 66138 55310 -16.4% 1.20x
CharIteration_punctuatedJapanese_unicodeScalars_Backwards 52510 44078 -16.1% 1.19x
CharIteration_utf16_unicodeScalars_Backwards 249009 219512 -11.8% 1.13x
DictionaryCompactMapValuesOfCastValue 109579 99017 -9.6% 1.11x
MonteCarloE 1236852 1147753 -7.2% 1.08x
ArraySubscript 115102 107035 -7.0% 1.08x
MonteCarloPi 5643028 5257793 -6.8% 1.07x

Code size: Swift libraries

TEST OLD NEW DELTA RATIO
Improvement
libswiftCore.dylib 3911680 3813376 -2.5% 1.03x
How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false alarms. Unexpected regressions which are marked with '(?)' are probably noise. If you see regressions which you cannot explain you can try to run the benchmarks again. If regressions still show up, please consult with the performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.