New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert that tap vars are in the current DeclContext #20303

Merged
merged 1 commit into from Nov 14, 2018

Conversation

Projects
None yet
2 participants
@brentdax
Collaborator

brentdax commented Nov 3, 2018

This assertion would have caught the last-minute bug in the string interpolation rework, but I'm not sure it actually holds in all cases—I've already found one exception (single-expression closures) and there may be others.

I'm running it against more code to see if there are other special cases I need to account for, or if this is not a general rule I can rely on.

@brentdax

This comment has been minimized.

Collaborator

brentdax commented Nov 3, 2018

@swift-ci please test

@brentdax

This comment has been minimized.

Collaborator

brentdax commented Nov 3, 2018

@swift-ci please test source compatibility

@swift-ci

This comment has been minimized.

Contributor

swift-ci commented Nov 3, 2018

Build failed
Swift Test Linux Platform
Git Sha - efd164f

@brentdax

This comment has been minimized.

Collaborator

brentdax commented Nov 5, 2018

Flaky Linux test strikes again.

@brentdax

This comment has been minimized.

Collaborator

brentdax commented Nov 5, 2018

@swift-ci please test linux platform

@swift-ci

This comment has been minimized.

Contributor

swift-ci commented Nov 5, 2018

Build failed
Swift Test Linux Platform
Git Sha - efd164f

[Sema] Assert that tap vars are in the current DeclContext
This assertion would have caught the last-minute bug in the string interpolation rework.
@brentdax

This comment has been minimized.

Collaborator

brentdax commented Nov 6, 2018

@swift-ci please test source compatibility

@brentdax

This comment has been minimized.

Collaborator

brentdax commented Nov 6, 2018

@swift-ci please smoke test

@brentdax brentdax changed the title from [DO NOT MERGE] Assert that tap vars are in the current DeclContext to Assert that tap vars are in the current DeclContext Nov 6, 2018

@brentdax brentdax requested a review from xedin Nov 6, 2018

@brentdax

This comment has been minimized.

Collaborator

brentdax commented Nov 12, 2018

@swift-ci please test source compatibility

@brentdax

This comment has been minimized.

Collaborator

brentdax commented Nov 14, 2018

The Tagged source compatibility failure is known to be caused by something else.

@brentdax brentdax merged commit 8c969b8 into apple:master Nov 14, 2018

2 of 4 checks passed

Swift Source Compatibility Suite on macOS Platform (Debug)
Details
Swift Source Compatibility Suite on macOS Platform (Release)
Details
Swift Test Linux Platform (smoke test)
Details
Swift Test OS X Platform (smoke test)
Details

@brentdax brentdax deleted the brentdax:asserting-my-correctness branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment