Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-933] rename flatten to flattened #2038

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@frootloops
Copy link
Contributor

commented Apr 2, 2016

What's in this pull request?

The 'flatten()' method didn't get the Swift 3 API renaming treatment it should have, to go along with reversed, sorted, joined, etc.

So I renamed the function.

Resolved bug number: (SR-933)


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
OS X platform @swift-ci Please test OS X platform
Linux platform @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

@frootloops frootloops force-pushed the frootloops:flattened branch Apr 3, 2016

@gribozavr

This comment has been minimized.

Copy link
Collaborator

commented Apr 7, 2016

@dabrahams @moiseev What do you think? Looks like a good change to me, but unfortunately, requires a short proposal on swift-evolution.

@frootloops frootloops force-pushed the frootloops:flattened branch to 77d5a0b Apr 7, 2016

@moiseev

This comment has been minimized.

Copy link
Member

commented Apr 7, 2016

👍
Perhaps s/FlattenSequence/FlattenedSequence as well, for completeness.

@frootloops frootloops force-pushed the frootloops:flattened branch to bc48ba4 Apr 8, 2016

@frootloops

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2016

@moiseev @gribozavr don't you think now we have to rename them all (mapped, filtered, flatMapped, reduced, and flattened) ?

@moiseev

This comment has been minimized.

Copy link
Member

commented Apr 8, 2016

@frootloops not really. The type prefix so far matches the function name. ReversedCollection and reversed() for example.

@frootloops

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2016

@moiseev @gribozavr Ok. What we gonna do with this pull request?

@frootloops frootloops closed this Apr 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.