New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Add missing "executable_test" requirements #21050

Merged
merged 1 commit into from Dec 6, 2018

Conversation

Projects
None yet
4 participants
@jrose-apple
Member

jrose-apple commented Dec 5, 2018

These keep the tests from failing when running for device targets with --param swift_test_mode=only_non_executable.

@jrose-apple jrose-apple requested review from brentdax and aschwaighofer Dec 5, 2018

@@ -1,5 +1,8 @@
// RUN: %target-typecheck-verify-swift -swift-version 4.2
// RUN: %target-run-simple-swift -swift-version 4.2 %s | %FileCheck %s
// RUN: %target-build-swift -swift-version 4.2 %s -o %t
// RUN: %target-run %t | %FileCheck %s

This comment has been minimized.

@jrose-apple

jrose-apple Dec 5, 2018

Member

@brentdax I tweaked this as well because %target-run-simple-swift passes its arguments to the executable, not to the compiler. At the moment the test suite's still being run in pre-Swift-5 mode anyway so it didn't change anything.

This comment has been minimized.

@slavapestov

slavapestov Dec 5, 2018

Member

@brentdax Also it might be good to create a new executable test for this in test/Interpreter, so that test/Parse remains non-executable, even if it requires duplicating some test code.

This comment has been minimized.

@brentdax

brentdax Dec 6, 2018

Collaborator

I'm fine with the test being moved or split—I didn't realize we were trying to keep that directory non-executable. Do you want me to do that?

@jrose-apple

This comment has been minimized.

Member

jrose-apple commented Dec 5, 2018

@swift-ci Please smoke test

@aschwaighofer

Thank you!

@jrose-apple jrose-apple force-pushed the jrose-apple:executable-expectations branch from 0be6996 to 79dfb8e Dec 5, 2018

@jrose-apple

This comment has been minimized.

Member

jrose-apple commented Dec 5, 2018

@swift-ci Please smoke test

@jrose-apple

This comment has been minimized.

Member

jrose-apple commented Dec 6, 2018

@swift-ci Please smoke test macOS

@jrose-apple jrose-apple merged commit b126768 into apple:master Dec 6, 2018

2 checks passed

Swift Test Linux Platform (smoke test)
Details
Swift Test OS X Platform (smoke test)
Details

jshier added a commit to jshier/swift that referenced this pull request Dec 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment